Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2361223002: Update linux sysroot images from debian/wheezy to debian/jessie (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Daniele Castagna, fwang, tonikitoo, jbroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update linux sysroot images from debian/wheezy to debian/jessie BUG=564904 Review-Url: https://codereview.chromium.org/2361223002 Cr-Commit-Position: refs/heads/master@{#456441} Committed: https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e840e9207bef9

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : Update sysroot images #

Patch Set 6 : . #

Total comments: 6

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : Update sysroot images #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -46 lines) Patch
M build/config/sysroot.gni View 1 2 3 4 5 2 chunks +6 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 2 3 4 5 6 7 4 chunks +25 lines, -33 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 92 (57 generated)
Sam Clegg
cloned from https://codereview.chromium.org/1665223002/ Waiting for official bots to be updated to trusty before we can ...
4 years, 3 months ago (2016-09-22 20:35:47 UTC) #4
Sam Clegg
On 2016/09/22 20:35:47, Sam Clegg wrote: > cloned from https://codereview.chromium.org/1665223002/ > > Waiting for official ...
4 years, 3 months ago (2016-09-22 20:36:13 UTC) #5
Sam Clegg
On 2016/09/22 20:35:47, Sam Clegg wrote: > cloned from https://codereview.chromium.org/1665223002/ > > Waiting for official ...
4 years, 3 months ago (2016-09-22 20:36:14 UTC) #6
Tom (Use chromium acct)
Thanks for this cl sbc@ I tried the same thing a few months ago: https://codereview.chromium.org/2343643004/ ...
4 years ago (2016-12-09 23:43:02 UTC) #18
Tom (Use chromium acct)
Can you also do an official build and double-check that debian/expected_deps_*_jessie and rpm/expected_deps_* are still ...
4 years ago (2016-12-12 17:52:15 UTC) #28
Paweł Hajdan Jr.
Fine for me, +1 to Tom's comments and I defer to him I verified we ...
4 years ago (2016-12-15 17:16:24 UTC) #37
Tom (Use chromium acct)
Hi sbc@. johnw@ says that all the bots are upgraded except for Android. Could you ...
4 years ago (2016-12-19 21:22:12 UTC) #38
Sam Clegg
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scripts/install-sysroot.py#newcode11 build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as Jessie is the first version ...
4 years ago (2016-12-20 21:40:21 UTC) #39
Sam Clegg
On 2016/12/20 21:40:21, Sam Clegg wrote: > https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scripts/install-sysroot.py > File build/linux/sysroot_scripts/install-sysroot.py (right): > > https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scripts/install-sysroot.py#newcode11 ...
4 years ago (2016-12-20 22:27:31 UTC) #42
Tom (Use chromium acct)
On 2016/12/20 22:27:31, Sam Clegg wrote: > On 2016/12/20 21:40:21, Sam Clegg wrote: > > ...
4 years ago (2016-12-20 22:34:11 UTC) #43
chromium-reviews
IIRC johnw@ told me all the builder but android ones were upgraded. That doesn't seem ...
4 years ago (2016-12-20 22:37:57 UTC) #44
johnw1
On 2016/12/20 22:37:57, chromium-reviews wrote: > IIRC johnw@ told me all the builder but android ...
4 years ago (2016-12-20 22:46:36 UTC) #45
sugoi1
Hi all, A new third_party library we're currently in the process of adding to Chromium ...
3 years, 11 months ago (2017-01-23 18:07:21 UTC) #48
Sam Clegg
On 2017/01/23 18:07:21, sugoi1 wrote: > Hi all, > > A new third_party library we're ...
3 years, 11 months ago (2017-01-23 18:43:56 UTC) #49
Tom (Use chromium acct)
On 2017/01/23 18:43:56, Sam Clegg wrote: > On 2017/01/23 18:07:21, sugoi1 wrote: > > Hi ...
3 years, 9 months ago (2017-03-03 01:54:15 UTC) #50
Paweł Hajdan Jr.
LGTM + dpranke@ (make sure to get Dirk's approval)
3 years, 9 months ago (2017-03-06 17:36:58 UTC) #54
Tom (Use chromium acct)
lgtm
3 years, 9 months ago (2017-03-07 00:20:24 UTC) #57
Dirk Pranke
lgtm w/ nits. https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py#newcode15 build/linux/sysroot_scripts/install-sysroot.py:15: # state of the Debian archived ...
3 years, 9 months ago (2017-03-07 00:21:04 UTC) #58
Sam Clegg
https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py#newcode15 build/linux/sysroot_scripts/install-sysroot.py:15: # state of the Debian archived but for consistency ...
3 years, 9 months ago (2017-03-07 14:48:53 UTC) #59
Sam Clegg
On 2017/03/07 14:48:53, Sam Clegg wrote: > https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py > File build/linux/sysroot_scripts/install-sysroot.py (right): > > https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_scripts/install-sysroot.py#newcode15 ...
3 years, 9 months ago (2017-03-07 19:02:55 UTC) #64
Dirk Pranke
On 2017/03/07 19:02:55, Sam Clegg wrote: > Any clues on what might be causing linux_chromium_rel_ng ...
3 years, 9 months ago (2017-03-07 22:25:26 UTC) #65
Sam Clegg
On 2017/03/07 22:25:26, Dirk Pranke wrote: > On 2017/03/07 19:02:55, Sam Clegg wrote: > > ...
3 years, 9 months ago (2017-03-09 18:06:34 UTC) #66
Sam Clegg
On 2017/03/09 18:06:34, Sam Clegg wrote: > On 2017/03/07 22:25:26, Dirk Pranke wrote: > > ...
3 years, 9 months ago (2017-03-11 00:36:50 UTC) #67
Lei Zhang
Super late to the party, but hey I'm slowly catching up lgtm. https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py ...
3 years, 9 months ago (2017-03-11 01:17:28 UTC) #72
Lei Zhang
Still got red bots though.
3 years, 9 months ago (2017-03-11 01:18:18 UTC) #73
Tom (Use chromium acct)
On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote: > Still got red bots though. Looks ...
3 years, 9 months ago (2017-03-11 01:35:29 UTC) #74
Sam Clegg
On 2017/03/11 01:35:29, Tom Anderson wrote: > On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote: ...
3 years, 9 months ago (2017-03-11 02:55:51 UTC) #75
Sam Clegg
On 2017/03/11 01:35:29, Tom Anderson wrote: > On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote: ...
3 years, 9 months ago (2017-03-11 02:55:52 UTC) #76
Tom (Use chromium acct)
On 2017/03/11 02:55:52, Sam Clegg wrote: > On 2017/03/11 01:35:29, Tom Anderson wrote: > > ...
3 years, 9 months ago (2017-03-11 03:03:41 UTC) #77
Sam Clegg
https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_scripts/install-sysroot.py File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_scripts/install-sysroot.py#newcode179 build/linux/sysroot_scripts/install-sysroot.py:179: if target_arch == 'amd64': On 2017/03/11 01:17:27, Lei Zhang ...
3 years, 9 months ago (2017-03-13 16:43:16 UTC) #84
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361223002/140001
3 years, 9 months ago (2017-03-13 16:43:41 UTC) #85
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e840e9207bef9
3 years, 9 months ago (2017-03-13 18:38:59 UTC) #89
Sam Clegg
On 2017/03/13 18:38:59, commit-bot: I haz the power wrote: > Committed patchset #8 (id:140001) as ...
3 years, 9 months ago (2017-03-13 19:03:49 UTC) #90
Sam Clegg
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/2743253004/ by sbc@chromium.org. ...
3 years, 9 months ago (2017-03-13 19:06:15 UTC) #91
Dirk Pranke
3 years, 9 months ago (2017-03-13 19:22:34 UTC) #92
Message was sent while issue was closed.
On 2017/03/13 19:06:15, Sam Clegg wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/2743253004/ by mailto:sbc@chromium.org.
> 
> The reason for reverting is: Broke the linux builder which it seems is still
on
> Precise..

Huh. I wonder how we missed upgrading that one :(.

Powered by Google App Engine
This is Rietveld 408576698