Update linux sysroot images from debian/wheezy to debian/jessie

Update linux sysroot images from debian/wheezy to debian/jessie

BUG=564904
Review-Url: https://codereview.chromium.org/2361223002
Cr-Commit-Position: refs/heads/master@{#456441}
Committed: https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e840e9207bef9

[Sam Clegg, 2016-09-22 20:29:12]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 20:29:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam Clegg, 2016-09-22 20:35:47]

sbc@chromium.org changed reviewers:
+ thestig@chromium.org

[Sam Clegg, 2016-09-22 20:35:47]

cloned from https://codereview.chromium.org/1665223002/

Waiting for official bots to be updated to trusty before we can proceed.

[Sam Clegg, 2016-09-22 20:36:13]

On 2016/09/22 20:35:47, Sam Clegg wrote:
> cloned from https://codereview.chromium.org/1665223002/
> 
> Waiting for official bots to be updated to trusty before we can proceed.

https://bugs.chromium.org/p/chromium/issues/detail?id=564904

[Sam Clegg, 2016-09-22 20:36:14]

On 2016/09/22 20:35:47, Sam Clegg wrote:
> cloned from https://codereview.chromium.org/1665223002/
> 
> Waiting for official bots to be updated to trusty before we can proceed.

https://bugs.chromium.org/p/chromium/issues/detail?id=564904

[commit-bot: I haz the power, 2016-09-22 20:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 20:50:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Sam Clegg, 2016-10-03 23:58:27]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:59:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:04:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam Clegg, 2016-10-10 18:29:17]

Description was changed from

==========
Update linux sysroot images from debian/wheezy to debian/jessie

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_arm
==========

to

==========
Update linux sysroot images from debian/wheezy to debian/jessie

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_arm
BUG=564904
==========

[Sam Clegg, 2016-10-10 18:29:47]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:30:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 18:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:50:37]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Tom (Use chromium acct), 2016-12-09 23:43:02]

Thanks for this cl sbc@

I tried the same thing a few months ago:
https://codereview.chromium.org/2343643004/

Please make sure to also add exceptions in tools/checklicenses/checklicenses.py
or else some builders on the main waterfall will fail

[Sam Clegg, 2016-12-10 00:19:55]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 00:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:22:13]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Tom (Use chromium acct), 2016-12-10 20:51:48]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 20:52:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 21:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 21:56:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom (Use chromium acct), 2016-12-12 17:52:14]

thomasanderson@google.com changed reviewers:
+ phajdan.jr@chromium.org

[Tom (Use chromium acct), 2016-12-12 17:52:15]

Can you also do an official build and double-check that
debian/expected_deps_*_jessie and rpm/expected_deps_* are still up-to-date?

also + phajdan.jr for review

https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as Jessie is
the first version with ARM64 support. This script
Please update these paragraphs

[Tom (Use chromium acct), 2016-12-12 17:52:28]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 17:53:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 21:50:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom (Use chromium acct), 2016-12-14 03:13:07]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 03:13:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:07:41]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[Paweł Hajdan Jr., 2016-12-15 17:16:24]

Fine for me, +1 to Tom's comments and I defer to him

I verified we no longer support Wheezy on
https://support.google.com/chrome/a/answer/7100626?hl=en . Does Chrome compiled
with new sysroot run on all other Linux platforms we support?

[Tom (Use chromium acct), 2016-12-19 21:22:12]

Hi sbc@.  johnw@ says that all the bots are upgraded except for Android.  Could
you try uploading/testing a new patch set?

[Sam Clegg, 2016-12-20 21:40:21]

https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as Jessie is
the first version with ARM64 support. This script
On 2016/12/12 17:52:15, Tom Anderson wrote:
> Please update these paragraphs

Done.

[Sam Clegg, 2016-12-20 21:40:30]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 21:41:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam Clegg, 2016-12-20 22:27:31]

On 2016/12/20 21:40:21, Sam Clegg wrote:
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> File build/linux/sysroot_scripts/install-sysroot.py (right):
> 
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as Jessie
is
> the first version with ARM64 support. This script
> On 2016/12/12 17:52:15, Tom Anderson wrote:
> > Please update these paragraphs
> 
> Done.

Seems like not all the trybots are on trusty yet.

At least the optional trybot that ran the linux_arm build:

https://build.chromium.org/p/tryserver.chromium.linux/buildslaves/slave718-c4

Looks like its still on precise to me.

[Tom (Use chromium acct), 2016-12-20 22:34:11]

On 2016/12/20 22:27:31, Sam Clegg wrote:
> On 2016/12/20 21:40:21, Sam Clegg wrote:
> >
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> > File build/linux/sysroot_scripts/install-sysroot.py (right):
> > 
> >
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> > build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as
Jessie
> is
> > the first version with ARM64 support. This script
> > On 2016/12/12 17:52:15, Tom Anderson wrote:
> > > Please update these paragraphs
> > 
> > Done.
> 
> Seems like not all the trybots are on trusty yet.
> 
> At least the optional trybot that ran the linux_arm build:
> 
> https://build.chromium.org/p/tryserver.chromium.linux/buildslaves/slave718-c4
> 
> Looks like its still on precise to me.

Hm, yeah, and slave250-c4 too...
dcastagna@ told me that johnw@ upgraded all the builders.  Maybe there was a
miscommunication, or those were overlooked during the upgrade?
+dcastagna@ and johnw@

[chromium-reviews, 2016-12-20 22:37:57]

IIRC johnw@ told me all the builder but android ones were upgraded.
That doesn't seem an android builder though.

On Tue, Dec 20, 2016 at 5:34 PM,  <thomasanderson@google.com> wrote:
> On 2016/12/20 22:27:31, Sam Clegg wrote:
>> On 2016/12/20 21:40:21, Sam Clegg wrote:
>> >
>>
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
>> > File build/linux/sysroot_scripts/install-sysroot.py (right):
>> >
>> >
>>
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
>> > build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as
> Jessie
>> is
>> > the first version with ARM64 support. This script
>> > On 2016/12/12 17:52:15, Tom Anderson wrote:
>> > > Please update these paragraphs
>> >
>> > Done.
>>
>> Seems like not all the trybots are on trusty yet.
>>
>> At least the optional trybot that ran the linux_arm build:
>>
>>
>>
https://build.chromium.org/p/tryserver.chromium.linux/buildslaves/slave718-c4
>>
>> Looks like its still on precise to me.
>
> Hm, yeah, and slave250-c4 too...
> dcastagna@ told me that johnw@ upgraded all the builders. Maybe there was a
> miscommunication, or those were overlooked during the upgrade?
> +dcastagna@ and johnw@
>
> https://codereview.chromium.org/2361223002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[johnw1, 2016-12-20 22:46:36]

On 2016/12/20 22:37:57, chromium-reviews wrote:
> IIRC johnw@ told me all the builder but android ones were upgraded.
> That doesn't seem an android builder though.
> 
> On Tue, Dec 20, 2016 at 5:34 PM,  <mailto:thomasanderson@google.com> wrote:
> > On 2016/12/20 22:27:31, Sam Clegg wrote:
> >> On 2016/12/20 21:40:21, Sam Clegg wrote:
> >> >
> >>
> >
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> >> > File build/linux/sysroot_scripts/install-sysroot.py (right):
> >> >
> >> >
> >>
> >
>
https://codereview.chromium.org/2361223002/diff/60001/build/linux/sysroot_scr...
> >> > build/linux/sysroot_scripts/install-sysroot.py:11: # Jessie sysroot as
> > Jessie
> >> is
> >> > the first version with ARM64 support. This script
> >> > On 2016/12/12 17:52:15, Tom Anderson wrote:
> >> > > Please update these paragraphs
> >> >
> >> > Done.
> >>
> >> Seems like not all the trybots are on trusty yet.
> >>
> >> At least the optional trybot that ran the linux_arm build:
> >>
> >>
> >>
> https://build.chromium.org/p/tryserver.chromium.linux/buildslaves/slave718-c4
> >>
> >> Looks like its still on precise to me.
> >
> > Hm, yeah, and slave250-c4 too...
> > dcastagna@ told me that johnw@ upgraded all the builders. Maybe there was a
> > miscommunication, or those were overlooked during the upgrade?
> > +dcastagna@ and johnw@
> >
> > https://codereview.chromium.org/2361223002/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

Hi,

I'm handing the Trusty upgrade for official waterfalls only:
https://bugs.chromium.org/p/chromium/issues/detail?id=564904
It looks like https://bugs.chromium.org/p/chromium/issues/detail?id=666825 was
opened for a bunch of tryserver.chromium.linux bots, but looking closer it seems
there are some gaps in that list. In that bug there's a link to a spreadsheet
tracking the overall effort (and it's a pretty big effort).

Thanks.

[commit-bot: I haz the power, 2016-12-20 23:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:09:40]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[sugoi1, 2017-01-23 18:07:21]

Hi all,

  A new third_party library we're currently in the process of adding to Chromium
seems to depend on this update on Linux for the standard library's version
update.
  I verified and it does indeed appear to solve our linking issues locally.
  Would anyone know the ETA for landing the sysroot update?

Thanks

[Sam Clegg, 2017-01-23 18:43:56]

On 2017/01/23 18:07:21, sugoi1 wrote:
> Hi all,
> 
>   A new third_party library we're currently in the process of adding to
Chromium
> seems to depend on this update on Linux for the standard library's version
> update.
>   I verified and it does indeed appear to solve our linking issues locally.
>   Would anyone know the ETA for landing the sysroot update?
> 
> Thanks

We are waiting for the last few bots (the optional trybots) to be updated to
trusty.  Bug is:  https://bugs.chromium.org/p/chromium/issues/detail?id=666825.

[Tom (Use chromium acct), 2017-03-03 01:54:15]

On 2017/01/23 18:43:56, Sam Clegg wrote:
> On 2017/01/23 18:07:21, sugoi1 wrote:
> > Hi all,
> > 
> >   A new third_party library we're currently in the process of adding to
> Chromium
> > seems to depend on this update on Linux for the standard library's version
> > update.
> >   I verified and it does indeed appear to solve our linking issues locally.
> >   Would anyone know the ETA for landing the sysroot update?
> > 
> > Thanks
> 
> We are waiting for the last few bots (the optional trybots) to be updated to
> trusty.  Bug is: 
https://bugs.chromium.org/p/chromium/issues/detail?id=666825.

Looks like this is now unblocked

[Sam Clegg, 2017-03-06 15:26:56]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 15:27:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2017-03-06 17:36:58]

phajdan.jr@chromium.org changed reviewers:
+ dpranke@chromium.org

[Paweł Hajdan Jr., 2017-03-06 17:36:58]

LGTM + dpranke@ (make sure to get Dirk's approval)

[commit-bot: I haz the power, 2017-03-06 18:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:49:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom (Use chromium acct), 2017-03-07 00:20:24]

lgtm

[Dirk Pranke, 2017-03-07 00:21:04]

lgtm w/ nits.

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:15: # state of the Debian
archived but for consistency we currently use a
Nit: "archived"?

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:19: # should also be updated
periodically to include upstream security fixed from
Nit: s/fixed/fixes

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:174: else:
Nit: you can actually change line 168 to an elif and dedent this block, I think?

[Sam Clegg, 2017-03-07 14:48:53]

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:15: # state of the Debian
archived but for consistency we currently use a
On 2017/03/07 00:21:04, Dirk Pranke wrote:
> Nit: "archived"?

Done.

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:19: # should also be updated
periodically to include upstream security fixed from
On 2017/03/07 00:21:04, Dirk Pranke wrote:
> Nit: s/fixed/fixes

Done.

https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:174: else:
On 2017/03/07 00:21:04, Dirk Pranke wrote:
> Nit: you can actually change line 168 to an elif and dedent this block, I
think?

Done.

[Sam Clegg, 2017-03-07 14:50:34]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:42:00]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm/build...)

[Sam Clegg, 2017-03-07 19:02:55]

On 2017/03/07 14:48:53, Sam Clegg wrote:
>
https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
> File build/linux/sysroot_scripts/install-sysroot.py (right):
> 
>
https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
> build/linux/sysroot_scripts/install-sysroot.py:15: # state of the Debian
> archived but for consistency we currently use a
> On 2017/03/07 00:21:04, Dirk Pranke wrote:
> > Nit: "archived"?
> 
> Done.
> 
>
https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
> build/linux/sysroot_scripts/install-sysroot.py:19: # should also be updated
> periodically to include upstream security fixed from
> On 2017/03/07 00:21:04, Dirk Pranke wrote:
> > Nit: s/fixed/fixes
> 
> Done.
> 
>
https://codereview.chromium.org/2361223002/diff/100001/build/linux/sysroot_sc...
> build/linux/sysroot_scripts/install-sysroot.py:174: else:
> On 2017/03/07 00:21:04, Dirk Pranke wrote:
> > Nit: you can actually change line 168 to an elif and dedent this block, I
> think?
> 
> Done.

Any clues on what might be causing linux_chromium_rel_ng failures?   (I will
take a deeper look myself when I am back in the office on Thursday).

[Dirk Pranke, 2017-03-07 22:25:26]

On 2017/03/07 19:02:55, Sam Clegg wrote:
> Any clues on what might be causing linux_chromium_rel_ng failures?   (I will
> take a deeper look myself when I am back in the office on Thursday).

I'm not sure offhand. It seems hard to believe that this CL would cause those
failures.

It's possible we had flakes or failures on the waterfall so I'm trying again to
see.

[Sam Clegg, 2017-03-09 18:06:34]

On 2017/03/07 22:25:26, Dirk Pranke wrote:
> On 2017/03/07 19:02:55, Sam Clegg wrote:
> > Any clues on what might be causing linux_chromium_rel_ng failures?   (I will
> > take a deeper look myself when I am back in the office on Thursday).
> 
> I'm not sure offhand. It seems hard to believe that this CL would cause those
> failures.
> 
> It's possible we had flakes or failures on the waterfall so I'm trying again
to
> see.

Local tests show that these two test really do fail with this patch applied:
 ProfileSyncServiceBookmarkTestWithData.Persistence
 ProfileSyncServiceBookmarkTestWithData.MergeExpectedIdenticalModels

I'll see if someone from the sync team can help me debug.

[Sam Clegg, 2017-03-11 00:36:50]

On 2017/03/09 18:06:34, Sam Clegg wrote:
> On 2017/03/07 22:25:26, Dirk Pranke wrote:
> > On 2017/03/07 19:02:55, Sam Clegg wrote:
> > > Any clues on what might be causing linux_chromium_rel_ng failures?   (I
will
> > > take a deeper look myself when I am back in the office on Thursday).
> > 
> > I'm not sure offhand. It seems hard to believe that this CL would cause
those
> > failures.
> > 
> > It's possible we had flakes or failures on the waterfall so I'm trying again
> to
> > see.
> 
> Local tests show that these two test really do fail with this patch applied:
>  ProfileSyncServiceBookmarkTestWithData.Persistence
>  ProfileSyncServiceBookmarkTestWithData.MergeExpectedIdenticalModels
> 
> I'll see if someone from the sync team can help me debug.

The sync team found a bug that this change exposed:
https://codereview.chromium.org/2743713005/

Pretty cool.  Just waiting on that to land now and we should be good to go.

[Sam Clegg, 2017-03-11 00:51:32]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:11:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2017-03-11 01:17:28]

Super late to the party, but hey I'm slowly catching up lgtm.

https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_sc...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:179: if target_arch == 'amd64':
You can write this as:

if target_arch not in VALID_ARCHS:
  raise Error(...)
InstallSysroot('Jessie', target_arch)

[Lei Zhang, 2017-03-11 01:18:18]

Still got red bots though.

[Tom (Use chromium acct), 2017-03-11 01:35:29]

On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote:
> Still got red bots though.

Looks like some gtk-related deprecation warnings in //remoting, so I guess that
makes this my problem :P
I'll try to have a patch landed for this today

[Sam Clegg, 2017-03-11 02:55:51]

On 2017/03/11 01:35:29, Tom Anderson wrote:
> On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote:
> > Still got red bots though.
> 
> Looks like some gtk-related deprecation warnings in //remoting, so I guess
that
> makes this my problem :P
> I'll try to have a patch landed for this today

Ah.. looks like we got broken by another change that landed a couple of days ago
:(
https://codereview.chromium.org/2670623002

[Sam Clegg, 2017-03-11 02:55:52]

On 2017/03/11 01:35:29, Tom Anderson wrote:
> On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote:
> > Still got red bots though.
> 
> Looks like some gtk-related deprecation warnings in //remoting, so I guess
that
> makes this my problem :P
> I'll try to have a patch landed for this today

Ah.. looks like we got broken by another change that landed a couple of days ago
:(
https://codereview.chromium.org/2670623002

[Tom (Use chromium acct), 2017-03-11 03:03:41]

On 2017/03/11 02:55:52, Sam Clegg wrote:
> On 2017/03/11 01:35:29, Tom Anderson wrote:
> > On 2017/03/11 01:18:18, Lei Zhang (super slow) wrote:
> > > Still got red bots though.
> > 
> > Looks like some gtk-related deprecation warnings in //remoting, so I guess
> that
> > makes this my problem :P
> > I'll try to have a patch landed for this today
> 
> Ah.. looks like we got broken by another change that landed a couple of days
ago
> :(
> https://codereview.chromium.org/2670623002

Should be fixed by https://codereview.chromium.org/2741943004

[Tom (Use chromium acct), 2017-03-11 03:29:26]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 03:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 05:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 05:06:09]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2017-03-13 16:43:13]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2017-03-13 16:43:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, phajdan.jr@chromium.org, thomasanderson@google.com,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2361223002/#ps140001
(title: "Update sysroot images")

[Sam Clegg, 2017-03-13 16:43:16]

https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_sc...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/2361223002/diff/120001/build/linux/sysroot_sc...
build/linux/sysroot_scripts/install-sysroot.py:179: if target_arch == 'amd64':
On 2017/03/11 01:17:27, Lei Zhang (super slow) wrote:
> You can write this as:
> 
> if target_arch not in VALID_ARCHS:
>   raise Error(...)
> InstallSysroot('Jessie', target_arch)

Done.

[commit-bot: I haz the power, 2017-03-13 16:43:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam Clegg, 2017-03-13 17:43:33]

Description was changed from

==========
Update linux sysroot images from debian/wheezy to debian/jessie

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_arm
BUG=564904
==========

to

==========
Update linux sysroot images from debian/wheezy to debian/jessie

BUG=564904
==========

[commit-bot: I haz the power, 2017-03-13 18:37:41]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489423393951080,
"parent_rev": "5052d1d653fdd1965ed4d9d66973b76bb8b48466", "commit_rev":
"8d4f1d731faf1e9564985cbec05e840e9207bef9"}

[commit-bot: I haz the power, 2017-03-13 18:38:55]

Description was changed from

==========
Update linux sysroot images from debian/wheezy to debian/jessie

BUG=564904
==========

to

==========
Update linux sysroot images from debian/wheezy to debian/jessie

BUG=564904

Review-Url: https://codereview.chromium.org/2361223002
Cr-Commit-Position: refs/heads/master@{#456441}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e...
==========

[commit-bot: I haz the power, 2017-03-13 18:38:59]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e...

[Sam Clegg, 2017-03-13 19:03:49]

On 2017/03/13 18:38:59, commit-bot: I haz the power wrote:
> Committed patchset #8 (id:140001) as
>
https://chromium.googlesource.com/chromium/src/+/8d4f1d731faf1e9564985cbec05e...

Looks like we broke at least one linux builder that is still on the precise:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder

[Sam Clegg, 2017-03-13 19:06:15]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2743253004/ by sbc@chromium.org.

The reason for reverting is: Broke the linux builder which it seems is still on
Precise..

[Dirk Pranke, 2017-03-13 19:22:34]

On 2017/03/13 19:06:15, Sam Clegg wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/2743253004/ by mailto:sbc@chromium.org.
> 
> The reason for reverting is: Broke the linux builder which it seems is still
on
> Precise..

Huh. I wonder how we missed upgrading that one :(.