Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2741943004: Gtk3: Silence deprecation warnings in //remoting (Closed)

Created:
3 years, 9 months ago by Tom Anderson
Modified:
3 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Silence deprecation warnings in //remoting This CL silences some deprecation warnings of Gtk symbols that were deprecated in version 3.14. This is to support the switch to the Jessie sysroot (https://codereview.chromium.org/2361223002/), which includes 3.14 headers. Ignoring these warnings is safe because the symbols will be included as long as Gtk3 is supported (but we WILL need to change this if/when we support Gtk4). TBR=wez@chromium.org BUG=700616 Review-Url: https://codereview.chromium.org/2741943004 Cr-Commit-Position: refs/heads/master@{#456270} Committed: https://chromium.googlesource.com/chromium/src/+/ac0b0fc3924e2586a072f8343376a1f295b3786a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M remoting/host/continue_window_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/disconnect_window_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/it2me/it2me_confirmation_dialog_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741943004/1
3 years, 9 months ago (2017-03-11 03:03:31 UTC) #4
Sam Clegg
On 2017/03/11 03:03:31, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-11 03:08:29 UTC) #5
Sam Clegg
lgtm (not OWNER)
3 years, 9 months ago (2017-03-11 03:08:50 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 03:15:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac0b0fc3924e2586a072f8343376...

Powered by Google App Engine
This is Rietveld 408576698