|
|
Created:
3 years, 10 months ago by Tom (Use chromium acct) Modified:
3 years, 9 months ago CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org, Elliot Glaysher, sky, Lei Zhang, Dirk Pranke Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux UI: Switch to the Gtk3 theme
Sets "use_gtk3 = true" by default.
BUG=79722
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng
> > Review-Url: https://codereview.chromium.org/2670623002
> > Cr-Commit-Position: refs/heads/master@{#452118}
> > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d681183a3d47b
> Review-Url: https://codereview.chromium.org/2670623002
> Cr-Commit-Position: refs/heads/master@{#454491}
> Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d13fde39e73283
Review-Url: https://codereview.chromium.org/2670623002
Cr-Original-Commit-Position: refs/heads/master@{#455596}
Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844cb89f24d4590
Review-Url: https://codereview.chromium.org/2670623002
Cr-Commit-Position: refs/heads/master@{#458263}
Committed: https://chromium.googlesource.com/chromium/src/+/0ff8b19608421be5fa5b53e90c097e4992723b90
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Only enable on 64-bit builds #
Messages
Total messages: 100 (77 generated)
erg@: I think we're almost ready to make the switch. Just need your approval and to wait for https://codereview.chromium.org/2665203005/ https://codereview.chromium.org/2624683002/ and the CL that adds gtk arrows back
erg@chromium.org changed reviewers: + erg@chromium.org
lgtm and good luck!
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #4 (id:100001) has been deleted
Patchset #3 (id:80001) has been deleted
Patchset #3 (id:120001) has been deleted
Patchset #2 (id:20001) has been deleted
thomasanderson@google.com changed reviewers: + mmoss@chromium.org
+mmoss for expected_deps_* +sky and estade fyi
On 2017/02/14 22:21:50, Tom Anderson wrote: > +mmoss for expected_deps_* > +sky and estade fyi cool
lgtm
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Linux UI: Switch to the Gtk3 theme BUG=79722 CC=erg@chromium.org ========== to ========== Linux UI: Switch to the Gtk3 theme BUG=79722 CC=erg@chromium.org ==========
Description was changed from ========== Linux UI: Switch to the Gtk3 theme BUG=79722 CC=erg@chromium.org ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org ==========
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487785011762340, "parent_rev": "c088d17506c14fbfbab1d34538dcca64a561e315", "commit_rev": "872a494bba52e597388aec738d9d681183a3d47b"}
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#452118} Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2711753004/ by fgorski@chromium.org. The reason for reverting is: Broke the build: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg... [3232/5256] CXX obj/chrome/browser/ui/libgtkui/libgtk3ui/native_theme_gtk3.o FAILED: obj/chrome/browser/ui/libgtkui/libgtk3ui/native_theme_gtk3.o /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/libgtkui/libgtk3ui/native_theme_gtk3.o.d -DLIBGTKUI_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"289944-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DUSE_GCONF -DUSE_CUPS -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_DIRECTWRITE_GASP_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -DUSING_V8_SHARED -I../.. -Igen -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gconf/2 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/dbus-1.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu/dbus-1.0/include -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu/glib-2.0/include -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../third_party/libwebp -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu/glib-2.0/include -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gtk-3.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/pango-1.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gio-unix-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/atk-1.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/cairo -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gdk-pixbuf-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/freetype2 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/pixman-1 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/libpng12 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gtk-3.0/unix-print -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gtk-3.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/atk-1.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/cairo -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gdk-pixbuf-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/pango-1.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/gio-unix-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/freetype2 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu/glib-2.0/include -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/pixman-1 -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/libpng12 -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/chrome -Igen/chrome -Igen/chrome -Igen/chrome -Igen/components -Igen/components -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/mesa/src/include -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_i386-sysroot/usr/include/nspr -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -Igen/ui/resources -Igen/ui/resources -Igen/ui/views/resources -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m32 -msse2 -mfpmath=sse -mmmx -momit-leaf-frame-pointer -pthread -mstack-alignment=16 -mstackrealign -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-block-capture-autoreleasing -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_wheezy_i386-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-unused-function -Wno-unused-local-typedef -Wno-header-guard -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c ../../chrome/browser/ui/libgtkui/native_theme_gtk3.cc -o obj/chrome/browser/ui/libgtkui/libgtk3ui/native_theme_gtk3.o ../../chrome/browser/ui/libgtkui/native_theme_gtk3.cc:542:74: error: missing sentinel in function call [-Werror,-Wsentinel] gtk_style_context_get(context, state, "min-height", &min_height, NULL); ^ , nullptr ../../build/linux/debian_wheezy_i386-sysroot/usr/include/gtk-3.0/gtk/gtkstylecontext.h:736:6: note: function has been explicitly marked sentinel here void gtk_style_context_get (GtkStyleContext *context, ^ 1 error generated..
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#452118} Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#452118} > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... ==========
Patchset #2 (id:140001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Relanding now that libgtk-3-0 has been installed on all bots. crbug.com/695541
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mmoss@chromium.org, erg@chromium.org Link to the patchset: https://codereview.chromium.org/2670623002/#ps160001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1488509552049310, "parent_rev": "c031d3984b2fe7a91e05d666410c20f151c8b86d", "commit_rev": "89be63a39b5014096115d3ec60d13fde39e73283"}
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#452118} > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#452118} > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#454491} Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:160001) has been created in https://codereview.chromium.org/2722313008/ by inferno@chromium.org. The reason for reverting is: Broke MSAN bots and ClusterFuzz bots. BUG=698239,698252.
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#452118} > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#454491} Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ==========
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng; > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ==========
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng; > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Relanding only on 64-bit builds. crbug.com/699669 has been filed to install libgtk-3-0 on the 32-bit clusterfuzz chroot. The MSAN errors are fixed with these CLs: https://codereview.chromium.org/2737783003/ https://codereview.chromium.org/2736173002/
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mmoss@chromium.org, erg@chromium.org Link to the patchset: https://codereview.chromium.org/2670623002/#ps180001 (title: "Only enable on 64-bit builds")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 180001, "attempt_start_ts": 1489015136496190, "parent_rev": "caa6a6165d28c3bb499fc0aec9bf391c6bda1578", "commit_rev": "072522801041708fba94498a1844cb89f24d4590"}
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#455596} Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:180001) as https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:180001) has been created in https://codereview.chromium.org/2754913002/ by thomasanderson@chromium.org. The reason for reverting is: Reverting to fix component builds on systems with Mir. Will reland (probably later today) once https://codereview.chromium.org/2756543002/ lands.
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#455596} Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#455596} Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844... ==========
On 2017/03/16 17:50:54, Thomas Anderson wrote: > A revert of this CL (patchset #3 id:180001) has been created in > https://codereview.chromium.org/2754913002/ by mailto:thomasanderson@chromium.org. > > The reason for reverting is: Reverting to fix component builds on systems with > Mir. > Will reland (probably later today) once > https://codereview.chromium.org/2756543002/ lands. Relanding this CL now that https://codereview.chromium.org/2756543002/ has landed to fix https://crbug.com/700120
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 180001, "attempt_start_ts": 1490057024192320, "parent_rev": "34d74089ce961adad864ed974ce27f7bdf270f17", "commit_rev": "0ff8b19608421be5fa5b53e90c097e4992723b90"}
Message was sent while issue was closed.
Description was changed from ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#455596} Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844... ========== to ========== Linux UI: Switch to the Gtk3 theme Sets "use_gtk3 = true" by default. BUG=79722 TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_32_ng > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d... > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d1... Review-Url: https://codereview.chromium.org/2670623002 Cr-Original-Commit-Position: refs/heads/master@{#455596} Committed: https://chromium.googlesource.com/chromium/src/+/072522801041708fba94498a1844... Review-Url: https://codereview.chromium.org/2670623002 Cr-Commit-Position: refs/heads/master@{#458263} Committed: https://chromium.googlesource.com/chromium/src/+/0ff8b19608421be5fa5b53e90c09... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:180001) as https://chromium.googlesource.com/chromium/src/+/0ff8b19608421be5fa5b53e90c09... |