[css-tables] Set needsLayout on cells when table border width changes

[css-tables] Set needsLayout on cells when table border width changes

When borders collapse, table borders affect cell widths but we weren't
marking cells properly. As a result cells and tables were using their
old widths.

BUG=613728
Committed: https://crrev.com/31dd85fea5e602d90f9b5372e0d5daaf05e2342e
Cr-Commit-Position: refs/heads/master@{#420193}

[dgrogan, 2016-09-20 23:06:23]

dgrogan@chromium.org changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-09-21 07:02:45]

lgtm.

Not sure if it's worthwhile to introduce this new method I'm suggesting. I'll
leave that decision to you. :)

https://codereview.chromium.org/2358663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTable.cpp (right):

https://codereview.chromium.org/2358663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTable.cpp:104: if
(LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *this, diff, *oldStyle))
{
The code here is almost identical to what we already have in
LayoutTableCol::styleDidChange().

Looks to me that we would benefit from a
LayoutTable::markAllCellsWidthsDirtyAndOrNeedsLayout(), which would call
markAllCellsWidthsDirtyAndOrNeedsLayout() on every section in the table.

But then again, no big deal.

[dgrogan, 2016-09-21 18:35:11]

There's enough change between the patchsets that I'll wait for another lgtm to
submit.

https://codereview.chromium.org/2358663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTable.cpp (right):

https://codereview.chromium.org/2358663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTable.cpp:104: if
(LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *this, diff, *oldStyle))
{
On 2016/09/21 07:02:45, mstensho wrote:
> The code here is almost identical to what we already have in
> LayoutTableCol::styleDidChange().
> 
> Looks to me that we would benefit from a
> LayoutTable::markAllCellsWidthsDirtyAndOrNeedsLayout(), which would call
> markAllCellsWidthsDirtyAndOrNeedsLayout() on every section in the table.
> 
> But then again, no big deal.

Good catch, refactored.

[mstensho (USE GERRIT), 2016-09-21 20:21:41]

lgtm++

[dgrogan, 2016-09-21 20:30:56]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:18:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 23:22:06]

Description was changed from

==========
[css-tables] Set needsLayout on cells when table border width changes

When borders collapse, table borders affect cell widths but we weren't
marking cells properly. As a result cells and tables were using their
old widths.

BUG=613728
==========

to

==========
[css-tables] Set needsLayout on cells when table border width changes

When borders collapse, table borders affect cell widths but we weren't
marking cells properly. As a result cells and tables were using their
old widths.

BUG=613728

Committed: https://crrev.com/31dd85fea5e602d90f9b5372e0d5daaf05e2342e
Cr-Commit-Position: refs/heads/master@{#420193}
==========

[commit-bot: I haz the power, 2016-09-21 23:22:07]

Patchset 2 (id:??) landed as
https://crrev.com/31dd85fea5e602d90f9b5372e0d5daaf05e2342e
Cr-Commit-Position: refs/heads/master@{#420193}