Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.h

Issue 2358663003: [css-tables] Set needsLayout on cells when table border width changes (Closed)
Patch Set: refactor some code into LayoutTable::markAllCellsWidthsDirty... Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2010 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 void subtractCaptionRect(LayoutRect&) const; 391 void subtractCaptionRect(LayoutRect&) const;
392 392
393 bool isLogicalWidthAuto() const; 393 bool isLogicalWidthAuto() const;
394 394
395 const char* name() const override { return "LayoutTable"; } 395 const char* name() const override { return "LayoutTable"; }
396 396
397 // Whether a table has opaque foreground depends on many factors, e.g. borde r spacing, missing cells, etc. 397 // Whether a table has opaque foreground depends on many factors, e.g. borde r spacing, missing cells, etc.
398 // For simplicity, just conservatively assume foreground of all tables are n ot opaque. 398 // For simplicity, just conservatively assume foreground of all tables are n ot opaque.
399 bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect&, unsigned) const ov erride { return false; } 399 bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect&, unsigned) const ov erride { return false; }
400 400
401 enum WhatToMarkAllCells { MarkDirtyOnly, MarkDirtyAndNeedsLayout };
402 void markAllCellsWidthsDirtyAndOrNeedsLayout(WhatToMarkAllCells);
403
401 protected: 404 protected:
402 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ; 405 void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override ;
403 void simplifiedNormalFlowLayout() override; 406 void simplifiedNormalFlowLayout() override;
404 bool recalcChildOverflowAfterStyleChange() override; 407 bool recalcChildOverflowAfterStyleChange() override;
405 void ensureIsReadyForPaintInvalidation() override; 408 void ensureIsReadyForPaintInvalidation() override;
406 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override; 409 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override;
407 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidatorContex t&) const override; 410 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidatorContex t&) const override;
408 411
409 private: 412 private:
410 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectTable || LayoutBlock::isOfType(type); } 413 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectTable || LayoutBlock::isOfType(type); }
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 if (m_firstBody) 519 if (m_firstBody)
517 return m_firstBody; 520 return m_firstBody;
518 return m_foot; 521 return m_foot;
519 } 522 }
520 523
521 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTable, isTable()); 524 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTable, isTable());
522 525
523 } // namespace blink 526 } // namespace blink
524 527
525 #endif // LayoutTable_h 528 #endif // LayoutTable_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698