third_party/WebKit/LayoutTests/fast/table/change-table-border-width.html - Issue 2358663003: [css-tables] Set needsLayout on cells when table border width changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/change-table-border-width.html

Issue 2358663003: [css-tables] Set needsLayout on cells when table border width changes (Closed)

Patch Set: refactor some code into LayoutTable::markAllCellsWidthsDirty... Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/table/change-table-border-width-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <style>	2 <style>

3 td {	3 td {

4 width: 50px;	4 width: 50px;

5 height: 50px;	5 height: 50px;

6 padding: 0px;	6 padding: 0px;

7 }	7 }

8 </style>	8 </style>

9 <script src="../../resources/check-layout.js"></script>	9 <script src="../../resources/check-layout.js"></script>

10 <script src="../../resources/run-after-layout-and-paint.js"></script>	10 <script src="../../resources/run-after-layout-and-paint.js"></script>

11 <script type="text/javascript">	11 <script type="text/javascript">

12 function shrinkColumnBorder() {	12 function shrinkTableBorder() {

13 theColumn.style.borderWidth = "4px";	13 theTable.style.borderWidth = "4px";

14 checkLayout("div");	14 checkLayout("div");

15 }	15 }

16 runAfterLayoutAndPaint(shrinkColumnBorder, true);	16 runAfterLayoutAndPaint(shrinkTableBorder, true);

17 </script>	17 </script>

18 <p>Changing a collapsed border's width should change the width of the table and the width of a shrink-to-fit containing block.</p>	18 <p>Changing a collapsed border's width should change the width of the table and the width of a shrink-to-fit containing block.</p>

19 <p>There should be a square with a 4px inner blue border and a 1px outer black b order.</p>	19 <p>There should be a square with a 4px inner blue border and a 1px outer black b order.</p>

20 <p>Firefox 50.0a1 (nightly 2016-07-14) fails this, so it should probably be upst reamed, except it uses chrome-specific `runAfterLayoutAndPaint`.</p>	20 <p>Firefox 52.0a1 (2016-09-20) fails this, so it should probably be upstreamed, except it uses chrome-specific `runAfterLayoutAndPaint`.</p>

21 <div style="float:left; border: 1px solid black" data-expected-width=60>	21 <div style="float:left; border: 1px solid black" data-expected-width=60>

22 <table style="border-collapse:collapse" data-expected-width=58 data-expected -height=58>	22 <table id=theTable style="border:18px solid lightblue; border-collapse:colla pse" data-expected-width=58 data-expected-height=58>

23 <col style="border:18px solid lightblue" id="theColumn">

24 <tr>	23 <tr>

25 <td></td>	24 <td></td>

26 </tr>	25 </tr>

27 </table>	26 </table>

28 </div>	27 </div>

OLD	NEW