[css-tables] Set needsLayout on cells when table border width changes

third_party/WebKit/Source/core/layout/LayoutTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 83 matching lines @@
         // explicit width is specified on the table.  Auto width implies auto table layout.
         if (style()->isFixedTableLayout())
             m_tableLayout = wrapUnique(new TableLayoutAlgorithmFixed(this));
         else
             m_tableLayout = wrapUnique(new TableLayoutAlgorithmAuto(this));
     }
 
     // If border was changed, invalidate collapsed borders cache.
     if (!needsLayout() && oldStyle && oldStyle->border() != style()->border())
         invalidateCollapsedBorders();
+    if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *this, diff, *oldStyle)) {

[mstensho (USE GERRIT), 2016/09/21 07:02:45]

The code here is almost identical to what we already have in
LayoutTableCol::styleDidChange().

Looks to me that we would benefit from a
LayoutTable::markAllCellsWidthsDirtyAndOrNeedsLayout(), which would call
markAllCellsWidthsDirtyAndOrNeedsLayout() on every section in the table.

But then again, no big deal.

[dgrogan, 2016/09/21 18:35:11]

Good catch, refactored.

+        for (LayoutObject* child = children()->firstChild(); child; child = child->nextSibling()) {
+            if (!child->isTableSection())
+                continue;
+            LayoutTableSection* section = toLayoutTableSection(child);
+            section->markAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTableSection::MarkDirtyAndNeedsLayout);
+        }
+    }
 }
 
 static inline void resetSectionPointerIfNotBefore(LayoutTableSection*& ptr, LayoutObject* before)
 {
     if (!before || !ptr)
         return;
     LayoutObject* o = before->previousSibling();
     while (o && o != ptr)
         o = o->previousSibling();
     if (!o)
@@ skipping 1362 matching lines @@
 
 LayoutUnit LayoutTable::paddingRight() const
 {
     if (collapseBorders())
         return LayoutUnit();
 
     return LayoutBlock::paddingRight();
 }
 
 } // namespace blink