Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2358663003: [css-tables] Set needsLayout on cells when table border width changes (Closed)
Patch Set: refactor some code into LayoutTable::markAllCellsWidthsDirty... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 67ffa078bd29636e2bddbc08d819cbcd9e414710..572670fc4188d4e2b7f8a1d276868b1499c4e0af 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -136,7 +136,7 @@ void LayoutTableSection::styleDidChange(StyleDifference diff, const ComputedStyl
table->invalidateCollapsedBorders();
if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *table, diff, *oldStyle))
- markAllCellsWidthsDirtyAndOrNeedsLayout(MarkDirtyAndNeedsLayout);
+ markAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTable::MarkDirtyAndNeedsLayout);
}
void LayoutTableSection::willBeRemovedFromTree()
@@ -1238,12 +1238,12 @@ bool LayoutTableSection::recalcChildOverflowAfterStyleChange()
return childrenOverflowChanged;
}
-void LayoutTableSection::markAllCellsWidthsDirtyAndOrNeedsLayout(WhatToMarkAllCells whatToMark)
+void LayoutTableSection::markAllCellsWidthsDirtyAndOrNeedsLayout(LayoutTable::WhatToMarkAllCells whatToMark)
{
for (LayoutTableRow* row = firstRow(); row; row = row->nextRow()) {
for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCell()) {
cell->setPreferredLogicalWidthsDirty();
- if (whatToMark == MarkDirtyAndNeedsLayout)
+ if (whatToMark == LayoutTable::MarkDirtyAndNeedsLayout)
cell->setChildNeedsLayout();
}
}

Powered by Google App Engine
This is Rietveld 408576698