Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2357533002: CC Animation: Use std::bitset to update animation state. (Closed)

Created:
4 years, 3 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Use std::bitset to update animation state. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/663ada2d888d28d7d219e9bf4f56b27b287bdb62 Cr-Commit-Position: refs/heads/master@{#422709}

Patch Set 1 #

Patch Set 2 : Transpose booleans. #

Patch Set 3 : Minor imrovements. #

Patch Set 4 : Pass by const ref. Optimize diff increment. #

Patch Set 5 : Clean it up. #

Total comments: 1

Patch Set 6 : Make UpdateClientAnimationState to consume void. Call it only if needed. #

Patch Set 7 : Align ActivateAnimations update with other updates. #

Patch Set 8 : Reparent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -799 lines) Patch
M cc/animation/animation_player.h View 1 2 3 4 5 6 7 5 chunks +4 lines, -11 lines 0 comments Download
M cc/animation/animation_player.cc View 1 2 3 4 5 6 7 15 chunks +56 lines, -89 lines 0 comments Download
M cc/animation/element_animations.h View 1 2 3 4 5 6 7 4 chunks +6 lines, -23 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 3 4 5 6 7 9 chunks +65 lines, -197 lines 0 comments Download
M cc/animation/property_animation_state.h View 1 1 chunk +8 lines, -4 lines 0 comments Download
M cc/animation/property_animation_state.cc View 1 2 3 4 3 chunks +28 lines, -33 lines 0 comments Download
M cc/animation/target_property.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/animation/target_property.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/layer.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -6 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 5 6 7 1 chunk +63 lines, -72 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -6 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 1 chunk +54 lines, -58 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 2 3 4 4 chunks +19 lines, -58 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 2 3 4 5 6 7 8 chunks +27 lines, -74 lines 0 comments Download
M cc/trees/layer_tree.h View 1 2 3 1 chunk +6 lines, -12 lines 0 comments Download
M cc/trees/layer_tree.cc View 1 2 3 1 chunk +6 lines, -62 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -69 lines 0 comments Download
M cc/trees/mutator_host_client.h View 1 2 3 2 chunks +7 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 41 (33 generated)
loyso (OOO)
4 years, 3 months ago (2016-09-21 07:47:10 UTC) #18
ajuma
lgtm
4 years, 3 months ago (2016-09-21 15:57:05 UTC) #21
loyso (OOO)
https://codereview.chromium.org/2357533002/diff/80001/cc/animation/element_animations.cc File cc/animation/element_animations.cc (right): https://codereview.chromium.org/2357533002/diff/80001/cc/animation/element_animations.cc#newcode474 cc/animation/element_animations.cc:474: TargetProperties properties) { Just realized last night that |properties| ...
4 years, 3 months ago (2016-09-22 00:47:29 UTC) #22
loyso (OOO)
PTAL! It's simpler now.
4 years, 3 months ago (2016-09-22 07:50:39 UTC) #25
ajuma
lgtm, thanks for the additional cleanup!
4 years, 3 months ago (2016-09-22 15:18:40 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357533002/140001
4 years, 2 months ago (2016-10-04 04:44:15 UTC) #37
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 2 months ago (2016-10-04 04:48:28 UTC) #39
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 04:49:46 UTC) #41
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/663ada2d888d28d7d219e9bf4f56b27b287bdb62
Cr-Commit-Position: refs/heads/master@{#422709}

Powered by Google App Engine
This is Rietveld 408576698