CC Animation: Extract PropertyAnimationState as a non-nested struct.

CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/cf6458cc14b04d5bf6852e1f2ce348fdd8040a8a
Cr-Commit-Position: refs/heads/master@{#422704}

[loyso (OOO), 2016-09-16 06:21:51]

Description was changed from

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

BUG=592873
==========

to

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-16 06:22:13]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[loyso (OOO), 2016-09-16 06:22:21]

Description was changed from

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-16 06:22:21]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org

[commit-bot: I haz the power, 2016-09-16 06:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-09-16 06:27:51]

Description was changed from

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-09-16 06:29:38]

loyso@chromium.org changed reviewers:
+ jaydasika@chromium.org

[commit-bot: I haz the power, 2016-09-16 07:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 07:23:16]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2016-09-16 16:05:33]

lgtm

[ajuma, 2016-09-16 16:50:52]

lgtm too

https://codereview.chromium.org/2349643003/diff/1/cc/animation/property_anima...
File cc/animation/property_animation_state.cc (right):

https://codereview.chromium.org/2349643003/diff/1/cc/animation/property_anima...
cc/animation/property_animation_state.cc:70: return
currently_running_for_active_elements <=
Code after a DCHECK should assume that the DCHECK holds (see
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...),
so I'd suggest removing these DCHECKs and depending on callers to DCHECK the
return value (and they already do that).

[loyso (OOO), 2016-09-19 02:44:02]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 02:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-09-19 02:45:35]

https://codereview.chromium.org/2349643003/diff/1/cc/animation/property_anima...
File cc/animation/property_animation_state.cc (right):

https://codereview.chromium.org/2349643003/diff/1/cc/animation/property_anima...
cc/animation/property_animation_state.cc:70: return
currently_running_for_active_elements <=
On 2016/09/16 16:50:52, ajuma wrote:
> Code after a DCHECK should assume that the DCHECK holds (see
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...),
> so I'd suggest removing these DCHECKs and depending on callers to DCHECK the
> return value (and they already do that).
Done.

[commit-bot: I haz the power, 2016-09-19 04:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 04:09:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[loyso (OOO), 2016-10-04 02:46:38]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 02:46:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 03:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:43:22]

Dry run: This issue passed the CQ dry run.

[loyso (OOO), 2016-10-04 04:13:43]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-10-04 04:13:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2349643003/#ps40001
(title: "Reparent to master to make it independent.")

[commit-bot: I haz the power, 2016-10-04 04:13:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 04:21:04]

Description was changed from

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-04 04:21:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 04:22:51]

Description was changed from

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Extract PropertyAnimationState as a non-nested struct.

Next step: Rework UpdateClientAnimationState to deal with
a bitset instead of single property
(batch, batch, batch)

BUG=592873
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/cf6458cc14b04d5bf6852e1f2ce348fdd8040a8a
Cr-Commit-Position: refs/heads/master@{#422704}
==========

[commit-bot: I haz the power, 2016-10-04 04:22:52]

Patchset 3 (id:??) landed as
https://crrev.com/cf6458cc14b04d5bf6852e1f2ce348fdd8040a8a
Cr-Commit-Position: refs/heads/master@{#422704}