Make SplitStringUsingSubstr have consistent args.

Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow callers to specify whitespace handling and what to do with empty items. This one variant still used the old signature and passed through the parameters to the same backend.

This patch makes the parameters match the other forms and removes the legacy versions. There should be no behavior change since this should end up calling the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)

Committed: https://crrev.com/8d858df953b8ef6f1424c1439be2594f1e99f1f1
Cr-Commit-Position: refs/heads/master@{#420562}

[brettw, 2016-09-22 22:40:24]

Description was changed from

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.
==========

to

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the remporary.
==========

[brettw, 2016-09-22 22:40:56]

brettw@chromium.org changed reviewers:
+ dcheng@chromium.org

[brettw, 2016-09-22 22:41:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:41:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:20:07]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-09-23 01:47:58]

lgtm

[brettw, 2016-09-23 02:08:51]

Description was changed from

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the remporary.
==========

to

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.
==========

[brettw, 2016-09-23 02:08:56]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:09:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:18:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-09-23 03:07:55]

Description was changed from

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.
==========

to

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)
==========

[brettw, 2016-09-23 03:08:18]

brettw@chromium.org changed reviewers:
+ bauerb@chromium.org

[brettw, 2016-09-23 03:08:19]

TBR=bauerb for webui owners for trivial update.

[brettw, 2016-09-23 03:08:25]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:08:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:13:52]

Description was changed from

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)
==========

to

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)
==========

[commit-bot: I haz the power, 2016-09-23 03:13:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 03:15:55]

Description was changed from

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)
==========

to

==========
Make SplitStringUsingSubstr have consistent args.

The other split string functions have a consistent set of arguments that allow
callers to specify whitespace handling and what to do with empty items. This one
variant still used the old signature and passed through the parameters to the
same backend.

This patch makes the parameters match the other forms and removes the legacy
versions. There should be no behavior change since this should end up calling
the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it
didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)

Committed: https://crrev.com/8d858df953b8ef6f1424c1439be2594f1e99f1f1
Cr-Commit-Position: refs/heads/master@{#420562}
==========

[commit-bot: I haz the power, 2016-09-23 03:15:56]

Patchset 1 (id:??) landed as
https://crrev.com/8d858df953b8ef6f1424c1439be2594f1e99f1f1
Cr-Commit-Position: refs/heads/master@{#420562}