Make SplitStringUsingSubstr have consistent args.

extensions/renderer/extensions_render_frame_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/extensions_render_frame_observer.h"
 
 #include <stddef.h>
 
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 22 matching lines @@
 StackTrace GetStackTraceFromMessage(base::string16* message,
                                     const base::string16& source,
                                     const base::string16& stack_trace,
                                     int32_t line_number) {
   StackTrace result;
   std::vector<base::string16> pieces;
   size_t index = 0;
 
   if (message->find(base::UTF8ToUTF16(kStackFrameDelimiter)) !=
           base::string16::npos) {
-    base::SplitStringUsingSubstr(*message,
-                                 base::UTF8ToUTF16(kStackFrameDelimiter),
-                                 &pieces);
+    pieces = base::SplitStringUsingSubstr(
+        *message, base::UTF8ToUTF16(kStackFrameDelimiter),
+        base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
     *message = pieces[0];
     index = 1;
   } else if (!stack_trace.empty()) {
-    base::SplitStringUsingSubstr(stack_trace,
-                                 base::UTF8ToUTF16(kStackFrameDelimiter),
-                                 &pieces);
+    pieces = base::SplitStringUsingSubstr(
+        stack_trace, base::UTF8ToUTF16(kStackFrameDelimiter),
+        base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
   }
 
   // If we got a stack trace, parse each frame from the text.
   if (index < pieces.size()) {
     for (; index < pieces.size(); ++index) {
       std::unique_ptr<StackFrame> frame =
           StackFrame::CreateFromText(pieces[index]);
       if (frame.get())
         result.push_back(*frame);
     }
@@ skipping 34 matching lines @@
       line_number);
   Send(new ExtensionHostMsg_DetailedConsoleMessageAdded(
       routing_id(), trimmed_message, source, stack_trace, severity_level));
 }
 
 void ExtensionsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
 }  // namespace extensions