Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5847)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_util.cc

Issue 2356253006: Make SplitStringUsingSubstr have consistent args. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/autofill_private/autofill_util.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_util.cc b/chrome/browser/extensions/api/autofill_private/autofill_util.cc
index 73ae3a8ee51d364297cf13059e48afe8e810dacf..6f6d7f976ffd01e7a49efed2e11f0c16da04f7bc 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_util.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_util.cc
@@ -101,8 +101,8 @@ autofill_private::AddressEntry ProfileToAddressEntry(
// Parse |label| so that it can be used to create address metadata.
base::string16 separator =
l10n_util::GetStringUTF16(IDS_AUTOFILL_ADDRESS_SUMMARY_SEPARATOR);
- std::vector<base::string16> label_pieces;
- base::SplitStringUsingSubstr(label, separator, &label_pieces);
+ std::vector<base::string16> label_pieces = base::SplitStringUsingSubstr(
+ label, separator, base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
// Create address metadata and add it to |address|.
std::unique_ptr<autofill_private::AutofillMetadata> metadata(

Powered by Google App Engine
This is Rietveld 408576698