chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc - Issue 2356253006: Make SplitStringUsingSubstr have consistent args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

Issue 2356253006: Make SplitStringUsingSubstr have consistent args. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/autofill_private/autofill_util.cc ('k') | chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

index bc1c18a766185d60f5a97f10b30e8877ad8dcb66..d6b28a91bdfce24b59a8994e91369d4d53b50594 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc

@@ -301,8 +301,8 @@ IN_PROC_BROWSER_TEST_F(WebrtcLoggingPrivateApiTest, TestStartStopUpload) {

EXPECT_NE(std::string::npos, log_part.find("Cpu brand:"));

// Check the multipart contents.

- std::vector<std::string> multipart_lines;

- base::SplitStringUsingSubstr(multipart, "\r\n", &multipart_lines);

+ std::vector<std::string> multipart_lines = base::SplitStringUsingSubstr(

+ multipart, "\r\n", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

ASSERT_EQ(31, static_cast<int>(multipart_lines.size()));

EXPECT_STREQ(&boundary[0], multipart_lines[0].c_str());