Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: chrome/browser/devtools/device/android_device_info_query.cc

Issue 2356253006: Make SplitStringUsingSubstr have consistent args. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/android_device_info_query.cc
diff --git a/chrome/browser/devtools/device/android_device_info_query.cc b/chrome/browser/devtools/device/android_device_info_query.cc
index 31f4b36f86405a86bd196babd58085c797071254..e16000b47e9964460a8db96bde9ebdaefd17813b 100644
--- a/chrome/browser/devtools/device/android_device_info_query.cc
+++ b/chrome/browser/devtools/device/android_device_info_query.cc
@@ -283,8 +283,8 @@ void ReceivedResponse(const AndroidDeviceManager::DeviceInfoCallback& callback,
callback.Run(device_info);
return;
}
- std::vector<std::string> outputs;
- base::SplitStringUsingSubstr(response, kSeparator, &outputs);
+ std::vector<std::string> outputs = base::SplitStringUsingSubstr(
+ response, kSeparator, base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (outputs.size() != 5) {
callback.Run(device_info);
return;
« no previous file with comments | « base/strings/string_split_unittest.cc ('k') | chrome/browser/extensions/api/autofill_private/autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698