Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2354713002: Delete dead code from metrics prototype (Closed)

Created:
4 years, 3 months ago by mgersh
Modified:
4 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete dead code from metrics prototype UrlRequestMetricsAccumulator is no longer used. BUG=629194 Committed: https://crrev.com/6ec2da77ac02ff2c1a918b2d265ec6aa4152fc66 Cr-Commit-Position: refs/heads/master@{#423224}

Patch Set 1 #

Patch Set 2 : missed one #

Patch Set 3 : rebase #

Patch Set 4 : ugh, flaky test, sorry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -62 lines) Patch
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java View 1 2 9 chunks +1 line, -54 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
mgersh
PTAL. This is follow-up from the other CL I just sent.
4 years, 3 months ago (2016-09-19 19:40:14 UTC) #2
xunjieli
lgtm
4 years, 3 months ago (2016-09-20 14:44:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354713002/60001
4 years, 2 months ago (2016-10-05 18:09:31 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-05 18:23:19 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:28:15 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6ec2da77ac02ff2c1a918b2d265ec6aa4152fc66
Cr-Commit-Position: refs/heads/master@{#423224}

Powered by Google App Engine
This is Rietveld 408576698