Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2349973006: Implement exception and finished reason in RequestFinishedInfo (Closed)

Created:
4 years, 3 months ago by mgersh
Modified:
4 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement exception and finished reason in RequestFinishedInfo BUG=629194, 610760 Committed: https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d Cr-Commit-Position: refs/heads/master@{#423241}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java View 1 6 chunks +9 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java View 1 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mgersh
4 years, 3 months ago (2016-09-19 22:26:37 UTC) #2
xunjieli
LGTM
4 years, 3 months ago (2016-09-20 14:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349973006/40001
4 years, 2 months ago (2016-10-05 18:54:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 19:08:10 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:11:19 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e6caadf0b95430f4d3ae0244bdfb0a6b0b55c24d
Cr-Commit-Position: refs/heads/master@{#423241}

Powered by Google App Engine
This is Rietveld 408576698