Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2354713002: Delete dead code from metrics prototype (Closed)
Patch Set: ugh, flaky test, sorry Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index 55988a598b2dc6ad4f05dc058525d32d76ddb0ee..3030932fb3f29636a501ab9fc48523ccd90c40d4 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -237,13 +237,15 @@ public class RequestFinishedInfoTest extends CronetTestBase {
// Check the timing metrics
assertNotNull(metrics.getRequestStart());
- assertTrue(metrics.getRequestStart().after(startTime));
+ assertTrue(metrics.getRequestStart().after(startTime)
+ || metrics.getRequestStart().equals(startTime));
MetricsTestUtil.checkNoConnectTiming(metrics);
assertNull(metrics.getSendingStart());
assertNull(metrics.getSendingEnd());
assertNull(metrics.getResponseStart());
assertNotNull(metrics.getResponseEnd());
- assertTrue(metrics.getResponseEnd().before(endTime));
+ assertTrue(metrics.getResponseEnd().before(endTime)
+ || metrics.getResponseEnd().equals(endTime));
// Entire request should take more than 0 ms
assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart().getTime() > 0);
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698