components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java - Issue 2354713002: Delete dead code from metrics prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2354713002: Delete dead code from metrics prototype (Closed)

Patch Set: ugh, flaky test, sorry Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

index d5f5259c7aba2039d7c58472769a924a379db581..819347d57a1cad185362e7e0315d0afc3d09fe71 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

@@ -193,13 +193,8 @@ public class CronetUrlRequestContext extends CronetEngine {

boolean disableConnectionMigration, boolean allowDirectExecutor) {

synchronized (mLock) {

checkHaveAdapter();

- boolean metricsCollectionEnabled = false;

- synchronized (mFinishedListenerLock) {

- metricsCollectionEnabled = !mFinishedListenerList.isEmpty();

- }

return new CronetUrlRequest(this, url, priority, callback, executor, requestAnnotations,

- metricsCollectionEnabled, disableCache, disableConnectionMigration,

- allowDirectExecutor);

+ disableCache, disableConnectionMigration, allowDirectExecutor);

}