Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2354713002: Delete dead code from metrics prototype (Closed)
Patch Set: ugh, flaky test, sorry Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import static org.chromium.base.CollectionUtil.newHashSet; 7 import static org.chromium.base.CollectionUtil.newHashSet;
8 8
9 import android.os.ConditionVariable; 9 import android.os.ConditionVariable;
10 import android.test.suitebuilder.annotation.SmallTest; 10 import android.test.suitebuilder.annotation.SmallTest;
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 assertEquals(connectionRefusedUrl, requestInfo.getUrl()); 230 assertEquals(connectionRefusedUrl, requestInfo.getUrl());
231 assertTrue(requestInfo.getAnnotations().isEmpty()); 231 assertTrue(requestInfo.getAnnotations().isEmpty());
232 RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics(); 232 RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
233 assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metri cs); 233 assertNotNull("RequestFinishedInfo.getMetrics() must not be null", metri cs);
234 // The failure is occasionally fast enough that time reported is 0, so j ust check for null 234 // The failure is occasionally fast enough that time reported is 0, so j ust check for null
235 assertNotNull(metrics.getTotalTimeMs()); 235 assertNotNull(metrics.getTotalTimeMs());
236 assertNull(metrics.getTtfbMs()); 236 assertNull(metrics.getTtfbMs());
237 237
238 // Check the timing metrics 238 // Check the timing metrics
239 assertNotNull(metrics.getRequestStart()); 239 assertNotNull(metrics.getRequestStart());
240 assertTrue(metrics.getRequestStart().after(startTime)); 240 assertTrue(metrics.getRequestStart().after(startTime)
241 || metrics.getRequestStart().equals(startTime));
241 MetricsTestUtil.checkNoConnectTiming(metrics); 242 MetricsTestUtil.checkNoConnectTiming(metrics);
242 assertNull(metrics.getSendingStart()); 243 assertNull(metrics.getSendingStart());
243 assertNull(metrics.getSendingEnd()); 244 assertNull(metrics.getSendingEnd());
244 assertNull(metrics.getResponseStart()); 245 assertNull(metrics.getResponseStart());
245 assertNotNull(metrics.getResponseEnd()); 246 assertNotNull(metrics.getResponseEnd());
246 assertTrue(metrics.getResponseEnd().before(endTime)); 247 assertTrue(metrics.getResponseEnd().before(endTime)
248 || metrics.getResponseEnd().equals(endTime));
247 // Entire request should take more than 0 ms 249 // Entire request should take more than 0 ms
248 assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart( ).getTime() > 0); 250 assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart( ).getTime() > 0);
249 251
250 assertTrue(metrics.getReceivedBytesCount() == null || metrics.getReceive dBytesCount() == 0); 252 assertTrue(metrics.getReceivedBytesCount() == null || metrics.getReceive dBytesCount() == 0);
251 mTestFramework.mCronetEngine.shutdown(); 253 mTestFramework.mCronetEngine.shutdown();
252 } 254 }
253 255
254 @SmallTest 256 @SmallTest
255 @OnlyRunNativeCronet 257 @OnlyRunNativeCronet
256 @Feature({"Cronet"}) 258 @Feature({"Cronet"})
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 assertEquals(new Date(sslEnd), metrics.getSslEnd()); 357 assertEquals(new Date(sslEnd), metrics.getSslEnd());
356 assertEquals(new Date(pushStart), metrics.getPushStart()); 358 assertEquals(new Date(pushStart), metrics.getPushStart());
357 assertEquals(new Date(pushEnd), metrics.getPushEnd()); 359 assertEquals(new Date(pushEnd), metrics.getPushEnd());
358 assertEquals(new Date(responseStart), metrics.getResponseStart()); 360 assertEquals(new Date(responseStart), metrics.getResponseStart());
359 assertEquals(new Date(responseEnd), metrics.getResponseEnd()); 361 assertEquals(new Date(responseEnd), metrics.getResponseEnd());
360 assertEquals(socketReused, metrics.getSocketReused()); 362 assertEquals(socketReused, metrics.getSocketReused());
361 assertEquals(sentBytesCount, (long) metrics.getSentBytesCount()); 363 assertEquals(sentBytesCount, (long) metrics.getSentBytesCount());
362 assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount()) ; 364 assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount()) ;
363 } 365 }
364 } 366 }
OLDNEW
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698