Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Expose left and right toolbar in TabbedPane. Previously we appended arbitrary elements before and after tab strip. This patch unifies them to be toolbars. BUG=none Committed: https://crrev.com/b7b5eb596e8e1a000348f9069dab71b4195f1bec Cr-Commit-Position: refs/heads/master@{#420149}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -239 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkPanel.css View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/heapProfiler.css View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 6 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 3 chunks +5 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 2 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 2 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 2 chunks +49 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorStyle.css View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorViewTabbedPane.css View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/splitWidget.css View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 2 chunks +17 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-09-20 19:32:20 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2353033004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2353033004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode114 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:114: WebInspector.Toolbar.appendLocationItems(toolbar, "styles-sidebarpane-toolbar"); You might want it on the ...
4 years, 3 months ago (2016-09-20 23:11:35 UTC) #3
dgozman
https://codereview.chromium.org/2353033004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2353033004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode114 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:114: WebInspector.Toolbar.appendLocationItems(toolbar, "styles-sidebarpane-toolbar"); On 2016/09/20 23:11:35, pfeldman wrote: > You ...
4 years, 3 months ago (2016-09-21 18:47:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353033004/20001
4 years, 3 months ago (2016-09-21 18:49:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 20:21:31 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:24:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7b5eb596e8e1a000348f9069dab71b4195f1bec
Cr-Commit-Position: refs/heads/master@{#420149}

Powered by Google App Engine
This is Rietveld 408576698