Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)
Patch Set: review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
index 98070c1b3a94797e61214e4d289b18e1624ab2e0..ac06a4f9254645399c57e7418c34e66b38e8f103 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
@@ -51,11 +51,9 @@ WebInspector.InspectorView = function()
this._drawerTabbedLocation.enableMoreTabsButton();
this._drawerTabbedPane = this._drawerTabbedLocation.tabbedPane();
this._drawerTabbedPane.setMinimumSize(0, 27);
- var drawerToolbar = new WebInspector.Toolbar("drawer-close-toolbar");
var closeDrawerButton = new WebInspector.ToolbarButton(WebInspector.UIString("Close drawer"), "delete-toolbar-item");
closeDrawerButton.addEventListener("click", this.closeDrawer.bind(this));
- drawerToolbar.appendToolbarItem(closeDrawerButton);
- this._drawerTabbedPane.appendAfterTabStrip(drawerToolbar.element);
+ this._drawerTabbedPane.rightToolbar().appendToolbarItem(closeDrawerButton);
this._drawerSplitWidget.installResizer(this._drawerTabbedPane.headerElement());
this._drawerSplitWidget.setSidebarWidget(this._drawerTabbedPane);
@@ -166,17 +164,8 @@ WebInspector.InspectorView.prototype = {
createToolbars: function()
{
- this._leftToolbar = new WebInspector.ExtensibleToolbar("main-toolbar-left");
- this._leftToolbar.element.classList.add("inspector-view-toolbar", "inspector-view-toolbar-left");
-
- this._tabbedPane.insertBeforeTabStrip(this._leftToolbar.element);
-
- var rightToolbarContainer = createElementWithClass("div", "hbox flex-none flex-centered");
- this._tabbedPane.appendAfterTabStrip(rightToolbarContainer);
-
- this._rightToolbar = new WebInspector.ExtensibleToolbar("main-toolbar-right");
- this._rightToolbar.element.classList.add("inspector-view-toolbar", "flex-none");
- rightToolbarContainer.appendChild(this._rightToolbar.element);
+ this._tabbedPane.leftToolbar().appendLocationItems("main-toolbar-left");
+ this._tabbedPane.rightToolbar().appendLocationItems("main-toolbar-right");
},
/**
@@ -253,10 +242,8 @@ WebInspector.InspectorView.prototype = {
{
this._currentPanelLocked = allTargetsSuspended;
this._tabbedPane.setCurrentTabLocked(this._currentPanelLocked);
- if (this._leftToolbar)
- this._leftToolbar.setEnabled(!this._currentPanelLocked);
- if (this._rightToolbar)
- this._rightToolbar.setEnabled(!this._currentPanelLocked);
+ this._tabbedPane.leftToolbar().setEnabled(!this._currentPanelLocked);
+ this._tabbedPane.rightToolbar().setEnabled(!this._currentPanelLocked);
},
/**

Powered by Google App Engine
This is Rietveld 408576698