Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)
Patch Set: review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
index 7af81db8b5a572c1d9f40d14b47a112f01449fb1..6b11f19719eef1679a0e20ae559762c2b3e74a50 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
@@ -41,12 +41,13 @@ WebInspector.SettingsScreen = function()
this.contentElement.tabIndex = 0;
this.contentElement.classList.add("help-window-main");
this.contentElement.classList.add("vbox");
- var settingsLabelElement = createElementWithClass("div", "help-window-label");
- settingsLabelElement.createTextChild(WebInspector.UIString("Settings"));
+
+ var settingsLabelElement = createElement("div");
+ WebInspector.createShadowRootWithCoreStyles(settingsLabelElement, "settings/settingsScreen.css").createChild("div", "settings-window-title").textContent = WebInspector.UIString("Settings");
this._tabbedLocation = WebInspector.viewManager.createTabbedLocation(() => WebInspector.SettingsScreen._showSettingsScreen(), "settings-view");
var tabbedPane = this._tabbedLocation.tabbedPane();
- tabbedPane.insertBeforeTabStrip(settingsLabelElement);
+ tabbedPane.leftToolbar().appendToolbarItem(new WebInspector.ToolbarItem(settingsLabelElement));
tabbedPane.setShrinkableTabs(false);
tabbedPane.setVerticalTabLayout(true);
var shortcutsView = new WebInspector.SimpleView(WebInspector.UIString("Shortcuts"));

Powered by Google App Engine
This is Rietveld 408576698