Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)
Patch Set: review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
index 375305e182ca0fee32107ae7da654ae060c7cfad..23d3c9565689f8ad6ec5462e922c6f0dd784d6de 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
@@ -883,20 +883,19 @@ WebInspector.SplitWidget.prototype = {
/**
* @param {string} title
- * @param {string=} className
- * @return {!Element}
+ * @return {!WebInspector.ToolbarButton}
*/
- displayShowHideSidebarButton: function(title, className)
+ createShowHideSidebarButton: function(title)
{
console.assert(this.isVertical(), "Buttons for split widget with horizontal split are not supported yet.");
this._showHideSidebarButtonTitle = WebInspector.UIString(title);
- this._showHideSidebarButton = this._mainElement.createChild("button", "sidebar-show-hide-button " + (className || ""));
- this._showHideSidebarButton.addEventListener("click", buttonClicked.bind(this), false);
+ this._showHideSidebarButton = new WebInspector.ToolbarButton("", "sidebar-toolbar-item");
+ this._showHideSidebarButton.addEventListener("click", buttonClicked.bind(this));
this._updateShowHideSidebarButton();
/**
- * @param {!Event} event
+ * @param {!WebInspector.Event} event
* @this {WebInspector.SplitWidget}
*/
function buttonClicked(event)
@@ -915,13 +914,8 @@ WebInspector.SplitWidget.prototype = {
if (!this._showHideSidebarButton)
return;
var sidebarHidden = this._showMode === WebInspector.SplitWidget.ShowMode.OnlyMain;
- this._showHideSidebarButton.classList.toggle("toggled-show", sidebarHidden);
- this._showHideSidebarButton.classList.toggle("toggled-hide", !sidebarHidden);
- this._showHideSidebarButton.classList.toggle("top-sidebar-show-hide-button", !this.isVertical() && !this.isSidebarSecond());
- this._showHideSidebarButton.classList.toggle("right-sidebar-show-hide-button", this.isVertical() && this.isSidebarSecond());
- this._showHideSidebarButton.classList.toggle("bottom-sidebar-show-hide-button", !this.isVertical() && this.isSidebarSecond());
- this._showHideSidebarButton.classList.toggle("left-sidebar-show-hide-button", this.isVertical() && !this.isSidebarSecond());
- this._showHideSidebarButton.title = sidebarHidden ? WebInspector.UIString("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hide %s", this._showHideSidebarButtonTitle);
+ this._showHideSidebarButton.setState((this.isSidebarSecond() ? "right" : "left") + "-" + (sidebarHidden ? "show" : "hide"));
+ this._showHideSidebarButton.setTitle(sidebarHidden ? WebInspector.UIString("Show %s", this._showHideSidebarButtonTitle) : WebInspector.UIString("Hide %s", this._showHideSidebarButtonTitle));
},
__proto__: WebInspector.Widget.prototype

Powered by Google App Engine
This is Rietveld 408576698