third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)

Patch Set: review comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/network/networkPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index db70f13343c8f1130d3497e3d3165ecc85c2ef10..4714f4c3083eec47d1ec5baf2fb46ef30b31dc29 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -82,7 +82,7 @@ WebInspector.NetworkPanel = function()

this._detailsWidget.element.classList.add("network-details-view");

this._splitWidget.setMainWidget(this._detailsWidget);

- this._closeButtonElement = createElementWithClass("div", "network-close-button", "dt-close-button");

+ this._closeButtonElement = createElement("div", "dt-close-button");

this._closeButtonElement.addEventListener("click", this._showRequest.bind(this, null), false);

this._networkLogShowOverviewSetting.addChangeListener(this._toggleShowOverview, this);

@@ -419,7 +419,7 @@ WebInspector.NetworkPanel.prototype = {

if (request) {

this._networkItemView = new WebInspector.NetworkItemView(request, this._networkLogView.timeCalculator());

- this._networkItemView.insertBeforeTabStrip(this._closeButtonElement);

+ this._networkItemView.leftToolbar().appendToolbarItem(new WebInspector.ToolbarItem(this._closeButtonElement));

this._networkItemView.show(this._detailsWidget.element);

this._splitWidget.showBoth();

} else {