BrowserOptions.extra_browser_args is now a set.

BrowserOptions.extra_browser_args is now a set.

Use AppendExtraBrowserArgs everywhere.

BUG=269131
TEST=trybot
TBR=kbr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221590

[achuithb, 2013-09-05 00:19:01]

What do you think of this patch, Tony? 

We're using AppendExtraBrowserArg inconsistently, sometimes using the function,
and sometimes accessing extra_browser_args directly. This fixes that.

[tonyg, 2013-09-05 00:26:14]

lgtm

This is awesome! Dave and I were literally just discussing this problem 10
minutes ago.

https://codereview.chromium.org/23512005/diff/3001/tools/perf/metrics/io.py
File tools/perf/metrics/io.py (right):

https://codereview.chromium.org/23512005/diff/3001/tools/perf/metrics/io.py#n...
tools/perf/metrics/io.py:12: options.extra_browser_args.add('--no-sandbox')
Don't we want to be using AppendExtraBrowserArgs here?

https://codereview.chromium.org/23512005/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/browser_options.py (right):

https://codereview.chromium.org/23512005/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/browser_options.py:36: self.extra_browser_args =
set()
I feel like we should change this to self._extra_browser_args and provide a
read-only @property extra_browser_args. That should prevent future misuse.

[achuithb, 2013-09-05 00:37:11]

PTAL. I missed the io.py somehow.

https://codereview.chromium.org/23512005/diff/3001/tools/perf/metrics/io.py
File tools/perf/metrics/io.py (right):

https://codereview.chromium.org/23512005/diff/3001/tools/perf/metrics/io.py#n...
tools/perf/metrics/io.py:12: options.extra_browser_args.add('--no-sandbox')
On 2013/09/05 00:26:15, tonyg wrote:
> Don't we want to be using AppendExtraBrowserArgs here?

Done.

https://codereview.chromium.org/23512005/diff/3001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/browser_options.py (right):

https://codereview.chromium.org/23512005/diff/3001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/browser_options.py:36: self.extra_browser_args =
set()
On 2013/09/05 00:26:15, tonyg wrote:
> I feel like we should change this to self._extra_browser_args and provide a
> read-only @property extra_browser_args. That should prevent future misuse.

Done.

[tonyg, 2013-09-05 00:47:14]

lgtm

[commit-bot: I haz the power, 2013-09-05 00:57:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23512005/10001

[commit-bot: I haz the power, 2013-09-05 02:27:23]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[achuithb, 2013-09-05 10:25:39]

Ken: need owner lgtm please for webgl_conformance.py

[commit-bot: I haz the power, 2013-09-05 17:58:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23512005/10001

[Ken Russell (switch to Gerrit), 2013-09-05 20:16:20]

LGTM for content/test/gpu/

[achuithb, 2013-09-05 20:24:26]

On 2013/09/05 20:16:20, Ken Russell wrote:
> LGTM for content/test/gpu/

ty!

[commit-bot: I haz the power, 2013-09-05 20:26:18]

Failed to apply patch for tools/perf/metrics/v8_object_stats.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/metrics/v8_object_stats.py
  Hunk #1 FAILED at 160.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/perf/metrics/v8_object_stats.py.rej

Patch:       tools/perf/metrics/v8_object_stats.py
Index: tools/perf/metrics/v8_object_stats.py
diff --git a/tools/perf/metrics/v8_object_stats.py
b/tools/perf/metrics/v8_object_stats.py
index
79b0fad92e0d8f57e7d6c9ceb456fc1465b9fdef..58a726b860f177a2fcaf30cd7158209c5348c506
100644
--- a/tools/perf/metrics/v8_object_stats.py
+++ b/tools/perf/metrics/v8_object_stats.py
@@ -160,10 +160,11 @@ class V8ObjectStatsMetric(Metric):
 
   @classmethod
   def CustomizeBrowserOptions(cls, options):
-    options.AppendExtraBrowserArg('--enable-stats-table')
-    options.AppendExtraBrowserArg('--enable-benchmarking')
-    options.AppendExtraBrowserArg(
-        '--js-flags=--track_gc_object_stats --expose_gc')
+    options.AppendExtraBrowserArgs([
+        '--enable-stats-table',
+        '--enable-benchmarking',
+        '--js-flags=--track_gc_object_stats --expose_gc'
+    ])
 
   def Start(self, page, tab):
     """Do Nothing."""

[commit-bot: I haz the power, 2013-09-05 20:49:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/23512005/45001

[commit-bot: I haz the power, 2013-09-06 05:51:25]

Change committed as 221590