BrowserOptions.extra_browser_args is now a set.

tools/perf/metrics/memory.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 from metrics import histogram_util
 from metrics import Metric
 
 _HISTOGRAMS = [
@@ skipping 18 matching lines @@
   def __init__(self, browser):
     super(MemoryMetric, self).__init__()
     self._browser = browser
     self._start_commit_charge = self._browser.memory_stats['SystemCommitCharge']
     self._memory_stats = None
     self._histogram_start = dict()
     self._histogram_delta = dict()
 
   @classmethod
   def CustomizeBrowserOptions(cls, options):
-    options.AppendExtraBrowserArg('--enable-stats-collection-bindings')
-    options.AppendExtraBrowserArg('--enable-memory-benchmarking')
-    # For a hard-coded set of Google pages (such as GMail), we produce custom
-    # memory histograms (V8.Something_gmail) instead of the generic histograms
-    # (V8.Something), if we detect that a renderer is only rendering this page
-    # and no other pages. For this test, we need to disable histogram
-    # customizing, so that we get the same generic histograms produced for all
-    # pages.
-    options.AppendExtraBrowserArg('--disable-histogram-customizer')
+    options.AppendExtraBrowserArgs([
+        '--enable-stats-collection-bindings',
+        '--enable-memory-benchmarking',
+        # For a hard-coded set of Google pages (such as GMail), we produce
+        # custom memory histograms (V8.Something_gmail) instead of the generic
+        # histograms (V8.Something), if we detect that a renderer is only
+        # rendering this page and no other pages. For this test, we need to
+        # disable histogram customizing, so that we get the same generic
+        # histograms produced for all pages.
+        '--disable-histogram-customizer',
 
-    # Old commandline flags used for reference builds.
-    options.AppendExtraBrowserArg('--dom-automation')
-    options.AppendExtraBrowserArg('--reduce-security-for-dom-automation-tests')
+        # Old commandline flags used for reference builds.
+        '--dom-automation',
+        '--reduce-security-for-dom-automation-tests',
+    ])
 
   def Start(self, page, tab):
     """Start the per-page preparation for this metric.
 
     Here, this consists of recording the start value of all the histograms.
     """
     for h in _HISTOGRAMS:
       histogram_data = histogram_util.GetHistogramFromDomAutomation(
           h['type'], h['name'], tab)
       # Histogram data may not be available
@@ skipping 74 matching lines @@
     AddSummariesForProcessTypes(['Gpu'], 'gpu')
     AddSummariesForProcessTypes(['Browser', 'Renderer', 'Gpu'], 'total')
 
     end_commit_charge = self._memory_stats['SystemCommitCharge']
     commit_charge_difference = end_commit_charge - self._start_commit_charge
     results.AddSummary('commit_charge', 'kb', commit_charge_difference,
                        data_type='unimportant')
     results.AddSummary('processes', 'count', self._memory_stats['ProcessCount'],
                        data_type='unimportant')