tools/perf/metrics/v8_object_stats.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/v8_object_stats.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/v8_object_stats.py

diff --git a/tools/perf/metrics/v8_object_stats.py b/tools/perf/metrics/v8_object_stats.py

index 22243252e3592e880dc0ef14a3776a9b9749cce4..ebb733f8f388c84dfef8eab8ad2b15045f41d37c 100644

--- a/tools/perf/metrics/v8_object_stats.py

+++ b/tools/perf/metrics/v8_object_stats.py

@@ -160,13 +160,14 @@ class V8ObjectStatsMetric(Metric):

@classmethod

def CustomizeBrowserOptions(cls, options):

- options.AppendExtraBrowserArg('--enable-stats-table')

- options.AppendExtraBrowserArg('--enable-benchmarking')

- options.AppendExtraBrowserArg(

- '--js-flags=--track_gc_object_stats --expose_gc')

- # TODO(rmcilroy): This is needed for --enable-stats-table. Update once

- # https://codereview.chromium.org/22911027/ lands.

- options.AppendExtraBrowserArg('--no-sandbox')

+ options.AppendExtraBrowserArgs([

+ '--enable-stats-table',

+ '--enable-benchmarking',

+ '--js-flags=--track_gc_object_stats --expose_gc',

+ # TODO(rmcilroy): This is needed for --enable-stats-table. Update once

+ # https://codereview.chromium.org/22911027/ lands.

+ '--no-sandbox'

+ ])

@staticmethod

def GetV8StatsTable(tab, counters=None):

« no previous file with comments | « tools/perf/metrics/smoothness.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »