tools/perf/metrics/io.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/metrics/io.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/perf/metrics/__init__.py ('k') | tools/perf/metrics/memory.py » ('j') | tools/telemetry/telemetry/core/browser_options.py » ('J')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from metrics import Metric	5 from metrics import Metric

6	6

7 class IOMetric(Metric):	7 class IOMetric(Metric):

8 """IO-related metrics, obtained via telemetry.core.Browser."""	8 """IO-related metrics, obtained via telemetry.core.Browser."""

9	9

10 @classmethod	10 @classmethod

11 def CustomizeBrowserOptions(cls, options):	11 def CustomizeBrowserOptions(cls, options):

12 options.AppendExtraBrowserArg('--no-sandbox')	12 options.extra_browser_args.add('--no-sandbox')
	tonyg 2013/09/05 00:26:15 Don't we want to be using AppendExtraBrowserArgs h Don't we want to be using AppendExtraBrowserArgs here? achuithb 2013/09/05 00:37:11 Done. Show quoted text On 2013/09/05 00:26:15, tonyg wrote: > Don't we want to be using AppendExtraBrowserArgs here? Done.
13	13

14 def Start(self, page, tab):	14 def Start(self, page, tab):

15 raise NotImplementedError()	15 raise NotImplementedError()

16	16

17 def Stop(self, page, tab):	17 def Stop(self, page, tab):

18 raise NotImplementedError()	18 raise NotImplementedError()

19	19

20 def AddResults(self, tab, results):	20 def AddResults(self, tab, results):

21 # This metric currently only returns summary results, not per-page results.	21 # This metric currently only returns summary results, not per-page results.

22 raise NotImplementedError()	22 raise NotImplementedError()

(...skipping 29 matching lines...) Expand all Loading...
52 if 'WriteTransferCount' in io_stats[process_type_io]:	52 if 'WriteTransferCount' in io_stats[process_type_io]:

53 results.AddSummary('write_bytes_' + process_type_trace, 'kb',	53 results.AddSummary('write_bytes_' + process_type_trace, 'kb',

54 io_stats[process_type_io]	54 io_stats[process_type_io]

55 ['WriteTransferCount'] / 1024,	55 ['WriteTransferCount'] / 1024,

56 data_type='unimportant')	56 data_type='unimportant')

57	57

58 AddSummariesForProcessType('Browser', 'browser')	58 AddSummariesForProcessType('Browser', 'browser')

59 AddSummariesForProcessType('Renderer', 'renderer')	59 AddSummariesForProcessType('Renderer', 'renderer')

60 AddSummariesForProcessType('Gpu', 'gpu')	60 AddSummariesForProcessType('Gpu', 'gpu')

61	61

OLD	NEW