tools/perf/measurements/skpicture_printer.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/skpicture_printer.py

diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py

index 00ded8a83718062b2cb47d5864971aa602b49693..2208d1cd41ff51df53e39b6804093da9aa1c2c8d 100644

--- a/tools/perf/measurements/skpicture_printer.py

+++ b/tools/perf/measurements/skpicture_printer.py

@@ -15,10 +15,10 @@ class SkpicturePrinter(page_measurement.PageMeasurement):

help='Output directory for the SKP files')

def CustomizeBrowserOptions(self, options):

- options.extra_browser_args.extend(['--enable-gpu-benchmarking',

- '--no-sandbox',

- '--enable-deferred-image-decoding',

- '--force-compositing-mode'])

+ options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',

+ '--no-sandbox',

+ '--enable-deferred-image-decoding',

+ '--force-compositing-mode'])

def MeasurePage(self, page, tab, results):

skp_outdir = self.options.skp_outdir