Turn FilterEffectBuilder into a stack-allocated helper

Turn FilterEffectBuilder into a stack-allocated helper

This moves the FilterEffect reference out of FilterEffectBuilder and
into the owner (PaintLayerFilterInfo), and then turns
FilterEffectBuilder into a more proper builder-style object that is
configured by the client and then has build...() called upon it to
construct the filter.
Rename the old build() method to buildFilterEffect().
Fix up PaintLayer to remove the indirection, and similarly adjust the
other users (CanvasRenderingContext2DState, SVGFilterPainter).

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7b071067f2fa8355f9b47dc7d5c9b2f4fe412efb
Cr-Commit-Position: refs/heads/master@{#419697}

[fs, 2016-09-19 12:40:25]

Description was changed from

==========
Turn FilterEffectBuilder into a stack-allocated helper

This moves the FilterEffect reference out of FilterEffectBuilder and
into the owner (PaintLayerFilterInfo), and then turns
FilterEffectBuilder into a more proper builder-style object that is
configured by the client and then has build...() called upon it to
construct the filter.
Rename the old build() method to buildFilterEffect().
Fix up PaintLayer to remove the indirection, and similarly adjust the
other users (CanvasRenderingContext2DState, SVGFilterPainter).

BUG=439970
==========

to

==========
Turn FilterEffectBuilder into a stack-allocated helper

This moves the FilterEffect reference out of FilterEffectBuilder and
into the owner (PaintLayerFilterInfo), and then turns
FilterEffectBuilder into a more proper builder-style object that is
configured by the client and then has build...() called upon it to
construct the filter.
Rename the old build() method to buildFilterEffect().
Fix up PaintLayer to remove the indirection, and similarly adjust the
other users (CanvasRenderingContext2DState, SVGFilterPainter).

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-19 12:40:32]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 12:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-19 13:49:32]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org, senorblanco@chromium.org

[commit-bot: I haz the power, 2016-09-19 13:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 13:54:06]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-09-19 14:59:36]

LGTM

https://codereview.chromium.org/2349183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp (right):

https://codereview.chromium.org/2349183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp:258: Filter*
FilterEffectBuilder::buildReferenceFilter(
I wonder if we should now just have two constructors for this builder
(with/without the node map), and a single buildReferenceFilter() function. Just
a thought.

[fs, 2016-09-20 08:17:28]

https://codereview.chromium.org/2349183002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp (right):

https://codereview.chromium.org/2349183002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp:258: Filter*
FilterEffectBuilder::buildReferenceFilter(
On 2016/09/19 at 14:59:36, Stephen White wrote:
> I wonder if we should now just have two constructors for this builder
(with/without the node map), and a single buildReferenceFilter() function. Just
a thought.

My plan is one constructor and one buildReferenceFilter(). Needs a bit more
massaging (on the SVG-side of things) before we're there though.

[fs, 2016-09-20 08:17:31]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-20 08:17:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:22:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 08:24:51]

Description was changed from

==========
Turn FilterEffectBuilder into a stack-allocated helper

This moves the FilterEffect reference out of FilterEffectBuilder and
into the owner (PaintLayerFilterInfo), and then turns
FilterEffectBuilder into a more proper builder-style object that is
configured by the client and then has build...() called upon it to
construct the filter.
Rename the old build() method to buildFilterEffect().
Fix up PaintLayer to remove the indirection, and similarly adjust the
other users (CanvasRenderingContext2DState, SVGFilterPainter).

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Turn FilterEffectBuilder into a stack-allocated helper

This moves the FilterEffect reference out of FilterEffectBuilder and
into the owner (PaintLayerFilterInfo), and then turns
FilterEffectBuilder into a more proper builder-style object that is
configured by the client and then has build...() called upon it to
construct the filter.
Rename the old build() method to buildFilterEffect().
Fix up PaintLayer to remove the indirection, and similarly adjust the
other users (CanvasRenderingContext2DState, SVGFilterPainter).

BUG=439970
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7b071067f2fa8355f9b47dc7d5c9b2f4fe412efb
Cr-Commit-Position: refs/heads/master@{#419697}
==========

[commit-bot: I haz the power, 2016-09-20 08:24:52]

Patchset 1 (id:??) landed as
https://crrev.com/7b071067f2fa8355f9b47dc7d5c9b2f4fe412efb
Cr-Commit-Position: refs/heads/master@{#419697}