third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp - Issue 2349183002: Turn FilterEffectBuilder into a stack-allocated helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

Issue 2349183002: Turn FilterEffectBuilder into a stack-allocated helper (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

index 49c035b3a1e6abc0f5b03271856be7154a227cff..74377c75563939cc2540135188a0b270a1574deb 100644

--- a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

@@ -87,9 +87,9 @@ GraphicsContext* SVGFilterPainter::prepareEffect(const LayoutObject& object, SVG

return nullptr;

}

- const FloatRect referenceBox = object.objectBoundingBox();

SVGFilterGraphNodeMap* nodeMap = SVGFilterGraphNodeMap::create();

- Filter* filter = FilterEffectBuilder::buildReferenceFilter(toSVGFilterElement(*m_filter.element()), referenceBox, nullptr, nullptr, nullptr, 1, nodeMap);

+ FilterEffectBuilder builder(nullptr, object.objectBoundingBox(), 1);

+ Filter* filter = builder.buildReferenceFilter(toSVGFilterElement(*m_filter.element()), nullptr, nodeMap);

if (!filter || !filter->lastEffect())

return nullptr;