Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.cpp

Issue 2349183002: Turn FilterEffectBuilder into a stack-allocated helper (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 11 matching lines...) Expand all
22 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 22 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
23 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR 24 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
25 * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 25 * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
26 * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 26 * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
27 * SUCH DAMAGE. 27 * SUCH DAMAGE.
28 */ 28 */
29 29
30 #include "core/paint/PaintLayerFilterInfo.h" 30 #include "core/paint/PaintLayerFilterInfo.h"
31 31
32 #include "core/paint/FilterEffectBuilder.h"
33 #include "core/paint/PaintLayer.h" 32 #include "core/paint/PaintLayer.h"
33 #include "platform/graphics/filters/FilterEffect.h"
34 #include "platform/graphics/filters/FilterOperations.h" 34 #include "platform/graphics/filters/FilterOperations.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 PaintLayerFilterInfo::PaintLayerFilterInfo(PaintLayer* layer) : m_layer(layer) { } 38 PaintLayerFilterInfo::PaintLayerFilterInfo(PaintLayer* layer) : m_layer(layer) { }
39 39
40 PaintLayerFilterInfo::~PaintLayerFilterInfo() 40 PaintLayerFilterInfo::~PaintLayerFilterInfo()
41 { 41 {
42 DCHECK(!m_layer); 42 DCHECK(!m_layer);
43 } 43 }
44 44
45 void PaintLayerFilterInfo::setBuilder(FilterEffectBuilder* builder) 45 void PaintLayerFilterInfo::setLastEffect(FilterEffect* lastEffect)
46 { 46 {
47 m_builder = builder; 47 m_lastEffect = lastEffect;
48 } 48 }
49 49
50 void PaintLayerFilterInfo::updateReferenceFilterClients(const FilterOperations& operations) 50 void PaintLayerFilterInfo::updateReferenceFilterClients(const FilterOperations& operations)
51 { 51 {
52 clearFilterReferences(); 52 clearFilterReferences();
53 addFilterReferences(operations, m_layer->layoutObject()->document()); 53 addFilterReferences(operations, m_layer->layoutObject()->document());
54 } 54 }
55 55
56 void PaintLayerFilterInfo::filterNeedsInvalidation() 56 void PaintLayerFilterInfo::filterNeedsInvalidation()
57 { 57 {
58 if (m_layer) 58 if (m_layer)
59 m_layer->filterNeedsPaintInvalidation(); 59 m_layer->filterNeedsPaintInvalidation();
60 } 60 }
61 61
62 DEFINE_TRACE(PaintLayerFilterInfo) 62 DEFINE_TRACE(PaintLayerFilterInfo)
63 { 63 {
64 visitor->trace(m_builder); 64 visitor->trace(m_lastEffect);
65 SVGResourceClient::trace(visitor); 65 SVGResourceClient::trace(visitor);
66 } 66 }
67 67
68 } // namespace blink 68 } // namespace blink
69 69
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698