Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h

Issue 2349183002: Turn FilterEffectBuilder into a stack-allocated helper (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h b/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
index c2673ada8fe622a194d59bd19bdd1b1e8cb6275a..7a2616d972966cb275ea43a3e283f4aca54d70b7 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h
@@ -33,12 +33,10 @@
#include "core/svg/SVGResourceClient.h"
#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace blink {
-class FilterEffectBuilder;
+class FilterEffect;
class FilterOperations;
class PaintLayer;
@@ -58,8 +56,8 @@ public:
explicit PaintLayerFilterInfo(PaintLayer*);
~PaintLayerFilterInfo() override;
- FilterEffectBuilder* builder() const { return m_builder.get(); }
- void setBuilder(FilterEffectBuilder*);
+ FilterEffect* lastEffect() const { return m_lastEffect; }
+ void setLastEffect(FilterEffect*);
void updateReferenceFilterClients(const FilterOperations&);
void clearLayer() { m_layer = nullptr; }
@@ -71,7 +69,7 @@ public:
private:
// |clearLayer| must be called before *m_layer becomes invalid.
PaintLayer* m_layer;
- Member<FilterEffectBuilder> m_builder;
+ Member<FilterEffect> m_lastEffect;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698