Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23486010: Adds a gfx_export.h to ui/gfx and converts all code in ui/gfx to (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rsesek+watch_chromium.org, cc-bugs_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

Adds a gfx_export.h to ui/gfx and converts all code in ui/gfx to include it rather than ui_export.h TBR=sky@chromium.org http://crbug.com/285385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221506

Patch Set 1 #

Patch Set 2 : Add the export file. #

Patch Set 3 : Fix find and replace error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -69 lines) Patch
M ui/gfx/android/device_display_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/blit.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_paint.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/codec/png_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_analysis.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/display.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/display_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/favicon_size.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_list.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_render_params_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gdi_util.h View 1 chunk +1 line, -1 line 0 comments Download
A ui/gfx/gfx_export.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M ui/gfx/gfx_paths.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_native_view_id_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_preserve_window.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gtk_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/cairo_cached_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/canvas_image_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_family.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_png_rep.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_rep.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_source.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_util_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_util_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/insets_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/native_widget_types.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/pango_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/path.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/path_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/path_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point3_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/point_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/quad_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/safe_integer_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/scrollbar_size.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/selection_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_value.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skbitmap_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skia_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skia_utils_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/sys_color_change_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/text_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/transform.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/transform_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector2d.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector2d_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector3d_f.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
7 years, 3 months ago (2013-09-04 22:00:25 UTC) #1
Ben Goodger (Google)
7 years, 3 months ago (2013-09-05 20:45:07 UTC) #2
Message was sent while issue was closed. 
Committed patchset #3 manually as r221506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698