Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2347293003: Rename any builder with prefix 'WebKit Linux' to 'WebKit Linux Precise' (Closed)

Created:
4 years, 3 months ago by jeffcarp
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 TBR=dpranke@chromium.org Committed: https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb Cr-Commit-Position: refs/heads/master@{#422581}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rename 'WebKit Linux' to 'WebKit Linux Precise' #

Patch Set 3 : Update more recent addition to WebKit Precise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M testing/buildbot/chromium.webkit.json View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py View 1 2 35 chunks +44 lines, -44 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 89 (47 generated)
jeffcarp
4 years, 3 months ago (2016-09-16 22:06:38 UTC) #1
qyearsley
Can't see any problems; I assume you searched for all instances of "WebKit Linux" being ...
4 years, 3 months ago (2016-09-16 22:16:11 UTC) #3
Dirk Pranke
Almost good, but see my important comments on https://codereview.chromium.org/2338293005/ . https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py (right): https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py#newcode38 ...
4 years, 3 months ago (2016-09-16 22:39:57 UTC) #4
jeffcarp
https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py (right): https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py#newcode38 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38: 'WebKit Linux Precise' : { On 2016/09/16 at 22:39:57, ...
4 years, 3 months ago (2016-09-21 19:21:50 UTC) #6
Dirk Pranke
On 2016/09/21 19:21:50, jeffcarp wrote: > https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py > File > third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py > (right): > > ...
4 years, 3 months ago (2016-09-21 21:17:14 UTC) #7
qyearsley
The CL description here could be updated now that CL # 1 is closed in ...
4 years, 2 months ago (2016-09-29 20:31:46 UTC) #8
qyearsley
On 2016/09/29 at 20:31:46, qyearsley wrote: > The CL description here could be updated now ...
4 years, 2 months ago (2016-09-29 20:32:57 UTC) #9
qyearsley
On 2016/09/29 at 20:32:57, qyearsley wrote: > On 2016/09/29 at 20:31:46, qyearsley wrote: > > ...
4 years, 2 months ago (2016-09-30 17:48:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/20001
4 years, 2 months ago (2016-09-30 18:21:08 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303020)
4 years, 2 months ago (2016-09-30 19:26:07 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/20001
4 years, 2 months ago (2016-09-30 19:48:01 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-09-30 20:10:28 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303146)
4 years, 2 months ago (2016-09-30 23:16:49 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-09-30 23:18:27 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303355)
4 years, 2 months ago (2016-10-01 01:27:58 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 01:30:25 UTC) #42
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-01 02:26:18 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303421)
4 years, 2 months ago (2016-10-01 03:07:23 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 03:08:34 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303452)
4 years, 2 months ago (2016-10-01 04:35:53 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 04:37:10 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303465)
4 years, 2 months ago (2016-10-01 06:12:51 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 06:17:50 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303479)
4 years, 2 months ago (2016-10-01 09:28:41 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 19:45:55 UTC) #59
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/303573)
4 years, 2 months ago (2016-10-01 21:55:55 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 22:01:53 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/308145)
4 years, 2 months ago (2016-10-01 22:23:26 UTC) #65
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-01 23:03:24 UTC) #67
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/306711)
4 years, 2 months ago (2016-10-02 00:06:49 UTC) #69
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-02 00:17:40 UTC) #71
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/306717)
4 years, 2 months ago (2016-10-02 01:12:59 UTC) #73
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-02 01:13:37 UTC) #75
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-02 01:56:28 UTC) #77
qyearsley
CQ is failing because some tests are failing at ToT; this is blocked on http://crrev.com/652014.
4 years, 2 months ago (2016-10-02 17:27:28 UTC) #78
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-03 15:52:09 UTC) #80
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-03 16:59:28 UTC) #82
qyearsley
On 2016/10/03 at 16:59:28, commit-bot wrote: > Exceeded global retry quota Last remaining CQ failure ...
4 years, 2 months ago (2016-10-03 21:16:46 UTC) #83
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347293003/40001
4 years, 2 months ago (2016-10-03 22:52:09 UTC) #85
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 22:58:49 UTC) #86
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb Cr-Commit-Position: refs/heads/master@{#422581}
4 years, 2 months ago (2016-10-03 23:03:20 UTC) #88
jeffcarp
4 years, 2 months ago (2016-10-03 23:32:00 UTC) #89
Message was sent while issue was closed.
On 2016/10/03 at 23:03:20, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb
> Cr-Commit-Position: refs/heads/master@{#422581}

YEEEEEEEESSSSSSSSSSSSSSS

Powered by Google App Engine
This is Rietveld 408576698