|
|
DescriptionRename 'WebKit Linux' to 'WebKit Linux Precise'
Note: this is 1 of 3 CLs in different repos:
1. build CLs split up:
- master: https://codereview.chromium.org/2382863002/
- slaves: https://codereview.chromium.org/2382723004/
2. https://codereview.chromium.org/2347293003 (chromium) [this one]
(Considering not landing this one)
3. https://chromium-review.googlesource.com/386326 (infra)
BUG=613305
TBR=dpranke@chromium.org
Committed: https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb
Cr-Commit-Position: refs/heads/master@{#422581}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Rename 'WebKit Linux' to 'WebKit Linux Precise' #Patch Set 3 : Update more recent addition to WebKit Precise #
Messages
Total messages: 89 (47 generated)
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org, qyearsley@chromium.org
Can't see any problems; I assume you searched for all instances of "WebKit Linux" being used, these are the instances in src?
Almost good, but see my important comments on https://codereview.chromium.org/2338293005/ . https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py (right): https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38: 'WebKit Linux Precise' : { Ideally we'd change these test cases to refer to a totally fake builder, so that we didn't have to change the tests when we change real revisions.
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. https://codereview.chromium.org/2338293005 (build) 2. https://codereview.chromium.org/2347293003 (chromium) [this one] 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 ==========
https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py (right): https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38: 'WebKit Linux Precise' : { On 2016/09/16 at 22:39:57, Dirk Pranke wrote: > Ideally we'd change these test cases to refer to a totally fake builder, so that we didn't have to change the tests when we change real revisions. That sounds good but sounds like it should be in a separate CL. Should I revert this file or leave it as-is so it matches the new WebKit Precise bots?
On 2016/09/21 19:21:50, jeffcarp wrote: > https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... > File > third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py > (right): > > https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Sc... > third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py:38: > 'WebKit Linux Precise' : { > On 2016/09/16 at 22:39:57, Dirk Pranke wrote: > > Ideally we'd change these test cases to refer to a totally fake builder, so > that we didn't have to change the tests when we change real revisions. > > That sounds good but sounds like it should be in a separate CL. Should I revert > this file or leave it as-is so it matches the new WebKit Precise bots? Matching the new stuff is probably better.
The CL description here could be updated now that CL # 1 is closed in favor of these two: https://codereview.chromium.org/2382863002 (build/masters/...) https://codereview.chromium.org/2382723004 (build/scripts/slave/...) https://codereview.chromium.org/2347293003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2347293003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:263: 'WebKit Linux Precise - WPTServe': 'swarming_gn_release_bot', Now these two lines can be reverted to how they were.
On 2016/09/29 at 20:31:46, qyearsley wrote: > The CL description here could be updated now that CL # 1 is closed in favor of these two: > https://codereview.chromium.org/2382863002 (build/masters/...) > https://codereview.chromium.org/2382723004 (build/scripts/slave/...) > Also: the CL title/description could note that (a) multiple builders are being renamed (b) this CL should include all changes in the src repo.
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. https://codereview.chromium.org/2338293005 (build) 2. https://codereview.chromium.org/2347293003 (chromium) [this one] 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 ==========
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/09/29 at 20:32:57, qyearsley wrote: > On 2016/09/29 at 20:31:46, qyearsley wrote: > > The CL description here could be updated now that CL # 1 is closed in favor of these two: > > https://codereview.chromium.org/2382863002 (build/masters/...) > > https://codereview.chromium.org/2382723004 (build/scripts/slave/...) > > > > Also: the CL title/description could note that (a) multiple builders are being renamed (b) this CL should include all changes in the src repo. LGTM -- Note, I believe that the WebKit Linux Precise builders are currently red because mb_config.pyl needs to be updated; I expect that they should be green after landing this. This CL needs LGTM from Dirk as well before passing the OWNERS check.
The CQ bit was checked by jeffcarp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by jeffcarp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 TBR=dpranke@chromium.org ==========
The CQ bit was unchecked by jeffcarp@chromium.org
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2347293003/#ps20001 (title: "Rename 'WebKit Linux' to 'WebKit Linux Precise'")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jeffcarp@chromium.org
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2347293003/#ps40001 (title: "Update more recent addition to WebKit Precise")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jeffcarp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
CQ is failing because some tests are failing at ToT; this is blocked on http://crrev.com/652014.
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
On 2016/10/03 at 16:59:28, commit-bot wrote: > Exceeded global retry quota Last remaining CQ failure (mac_chromium_rel_ng) *still* looks unrelated to this CL.
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 TBR=dpranke@chromium.org ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' Note: this is 1 of 3 CLs in different repos: 1. build CLs split up: - master: https://codereview.chromium.org/2382863002/ - slaves: https://codereview.chromium.org/2382723004/ 2. https://codereview.chromium.org/2347293003 (chromium) [this one] (Considering not landing this one) 3. https://chromium-review.googlesource.com/386326 (infra) BUG=613305 TBR=dpranke@chromium.org Committed: https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb Cr-Commit-Position: refs/heads/master@{#422581} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb Cr-Commit-Position: refs/heads/master@{#422581}
Message was sent while issue was closed.
On 2016/10/03 at 23:03:20, commit-bot wrote: > Patchset 3 (id:??) landed as https://crrev.com/520e37530ee98b49d0b58573212e67d4f9ea67bb > Cr-Commit-Position: refs/heads/master@{#422581} YEEEEEEEESSSSSSSSSSSSSSS |