Rename all 'WebKit Linux' builders to 'WebKit Linux Precise' (1/3 CLs)

Rename all 'WebKit Linux' builders to 'WebKit Linux Precise' (1/3 CLs)

Note: this is 1 of 3 CLs in different repos:

1. https://codereview.chromium.org/2338293005 (build) [this one]
2. https://codereview.chromium.org/2347293003 (chromium)
3. https://chromium-review.googlesource.com/386326 (infra)

BUG=613305

[qyearsley, 2016-09-16 22:14:27]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, qyearsley@chromium.org

[qyearsley, 2016-09-16 22:14:50]

I can't see any problems here.

[qyearsley, 2016-09-16 22:17:56]

On 2016/09/16 at 22:14:50, qyearsley wrote:
> I can't see any problems here.

Nit: The CL description could be updated to note that these are the instances in
the build repo, and there are also some more related changes in
https://codereview.chromium.org/2347293003 and
https://chromium-review.googlesource.com/386326.

[Dirk Pranke, 2016-09-16 22:39:42]

Almost good, but there's one minor caveat and one major one.

Minor caveat: update the CL to note that you're renaming several builders, not
just the one.

Major caveat: you need to think through the implications of landing this CL and
the other one, because depending on the order the CLs land, things will break.
It may be that in order to avoid breakages, you'll need to do additional work or
land more complicated CLs. It may be that breakages are actually unavoidable,
given the way the current system is implemented.

Can I leave this as an exercise for the readers (jeffcarp@ and qyearsley@) to
figure out what problems might arise and how you'll address them? If that's too
annoying, let me know and we can go over this together.

[jeffcarp, 2016-09-21 18:33:47]

Description was changed from

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise'

BUG=613305
==========

to

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise'

Note: this is 1 of 3 CLs in different repos:

1. https://codereview.chromium.org/2338293005 (build) [this one]
2. https://codereview.chromium.org/2347293003 (chromium)
3. https://chromium-review.googlesource.com/386326 (infra)

BUG=613305
==========

[jeffcarp, 2016-09-29 17:52:53]

Description was changed from

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise'

Note: this is 1 of 3 CLs in different repos:

1. https://codereview.chromium.org/2338293005 (build) [this one]
2. https://codereview.chromium.org/2347293003 (chromium)
3. https://chromium-review.googlesource.com/386326 (infra)

BUG=613305
==========

to

==========
Rename all 'WebKit Linux' builders to 'WebKit Linux Precise' (1/3 CLs)

Note: this is 1 of 3 CLs in different repos:

1. https://codereview.chromium.org/2338293005 (build) [this one]
2. https://codereview.chromium.org/2347293003 (chromium)
3. https://chromium-review.googlesource.com/386326 (infra)

BUG=613305
==========

[qyearsley, 2016-09-29 18:20:19]

Just discussed offline, and I suggested:

 (1) remove changes to chromium.fyi from this CL; all builders on chromium.fyi
should keep their current names; also, this way only chromium.webkit needs to be
restarted.
 (2) split off the changes in scripts/slave/... to a separate CL from the
changes to masters/...; then the change to master configs can be submitted
first, and all the other changes including changes to recipes can be submitted
together at approximately the same time as the master restart.

https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py (right):

https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py:366: 'WebKit
Linux Precise Trusty': {
Note: as discussed offline, this should still be "WebKit Linux Trusty"

[jeffcarp, 2016-09-29 18:29:36]

On 2016/09/29 at 18:20:19, qyearsley wrote:
> Just discussed offline, and I suggested:
> 
>  (1) remove changes to chromium.fyi from this CL; all builders on chromium.fyi
should keep their current names; also, this way only chromium.webkit needs to be
restarted.
>  (2) split off the changes in scripts/slave/... to a separate CL from the
changes to masters/...; then the change to master configs can be submitted
first, and all the other changes including changes to recipes can be submitted
together at approximately the same time as the master restart.
> 
>
https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py (right):
> 
>
https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py:366: 'WebKit
Linux Precise Trusty': {
> Note: as discussed offline, this should still be "WebKit Linux Trusty"

The two new CLs are:

- https://codereview.chromium.org/2382863002
- https://codereview.chromium.org/2382723004/

[qyearsley, 2016-09-29 19:17:50]

On 2016/09/29 at 18:29:36, jeffcarp wrote:
> On 2016/09/29 at 18:20:19, qyearsley wrote:
> > Just discussed offline, and I suggested:
> > 
> >  (1) remove changes to chromium.fyi from this CL; all builders on
chromium.fyi should keep their current names; also, this way only
chromium.webkit needs to be restarted.
> >  (2) split off the changes in scripts/slave/... to a separate CL from the
changes to masters/...; then the change to master configs can be submitted
first, and all the other changes including changes to recipes can be submitted
together at approximately the same time as the master restart.
> > 
> >
https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
> > File scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py (right):
> > 
> >
https://codereview.chromium.org/2338293005/diff/1/scripts/slave/recipe_module...
> > scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py:366: 'WebKit
Linux Precise Trusty': {
> > Note: as discussed offline, this should still be "WebKit Linux Trusty"
> 
> The two new CLs are:
> 
> - https://codereview.chromium.org/2382863002
> - https://codereview.chromium.org/2382723004/

Sounds good to me. Note, these two CLs will both require an L-G-T-M from Dirk
(or another build infra owner) before committing, I think.

Dirk, could you review those two when you have time?

(Closing this CL now since it's superseded by those two.)