Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2382863002:
Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master (Closed)
DescriptionRename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master
Our game plan is to:
1. Land a CL to rename the chromium.webkit master (this one)
2. Land a CL to rename chromium.webkit slaves (https://crrev.com/2382723004)
BUG=613305
Committed: https://chromium.googlesource.com/chromium/tools/build/+/801e0732bb06d042e62e1e9f0baa3bca8e00be6b
Patch Set 1 #
Total comments: 3
Patch Set 2 : Address comments #
Total comments: 1
Patch Set 3 : Fix >80 char lines #Patch Set 4 : Fix missed >80 char line #
Messages
Total messages: 27 (18 generated)
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: - Land a CL (this one) to rename the chromium.webkit master - Land a CL to rename chromium.webkit slaves BUG=613305 ==========
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: - Land a CL (this one) to rename the chromium.webkit master - Land a CL to rename chromium.webkit slaves BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master 2. Land a CL to rename chromium.webkit slaves BUG=613305 ==========
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master 2. Land a CL to rename chromium.webkit slaves BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master (CL 2382863002) 2. Land a CL to rename chromium.webkit slaves BUG=613305 ==========
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master (CL 2382863002) 2. Land a CL to rename chromium.webkit slaves BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master (https://crrev.com/2382863002) 2. Land a CL to rename chromium.webkit slaves BUG=613305 ==========
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL (this one) to rename the chromium.webkit master (https://crrev.com/2382863002) 2. Land a CL to rename chromium.webkit slaves BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL to rename the chromium.webkit master (this one) 2. Land a CL to rename chromium.webkit slaves (https://crrev.com/2382723004) BUG=613305 ==========
jeffcarp@chromium.org changed reviewers: + qyearsley@chromium.org
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org
https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... File masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py (right): https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:47: # FIXME: Rename this builder to indicate that it is running precise. This FIXME comment can be removed in this CL. https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:52: scheduler='global_scheduler') Optional formatting tweak: Looks like this is misaligned (although that's unrelated to this CL, so you can just leave it for now). https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... File masters/master.chromium.webkit/slaves.cfg (right): https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... masters/master.chromium.webkit/slaves.cfg:125: ### WebKit Linux Precise Latest To be consistent with the section header comments above, I this should still say "WebKit Linux Latest". (Although, I'm not really sure why it says "latest"; these section headers are probably unnecessary, I think, and could just say Win / Mac / Linux / Android.)
On 2016/09/29 at 19:15:25, qyearsley wrote: > https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... > File masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py (right): > > https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... > masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:47: # FIXME: Rename this builder to indicate that it is running precise. > This FIXME comment can be removed in this CL. > > https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... > masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:52: scheduler='global_scheduler') > Optional formatting tweak: Looks like this is misaligned (although that's unrelated to this CL, so you can just leave it for now). > > https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... > File masters/master.chromium.webkit/slaves.cfg (right): > > https://codereview.chromium.org/2382863002/diff/1/masters/master.chromium.web... > masters/master.chromium.webkit/slaves.cfg:125: ### WebKit Linux Precise Latest > To be consistent with the section header comments above, I this should still say "WebKit Linux Latest". > > (Although, I'm not really sure why it says "latest"; these section headers are probably unnecessary, I think, and could just say Win / Mac / Linux / Android.) Thanks, addressed your comments.
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31905ee92e5dfb10)
lgtm
https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... File masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py (right): https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:48: B('WebKit Linux Precise', 'f_webkit_linux_rel', scheduler='global_scheduler') Looks like these lines are now longer than 80 characters, which is making the presubmit script reject it.
On 2016/09/29 at 20:49:43, qyearsley wrote: > https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... > File masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py (right): > > https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... > masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:48: B('WebKit Linux Precise', 'f_webkit_linux_rel', scheduler='global_scheduler') > Looks like these lines are now longer than 80 characters, which is making the presubmit script reject it. Updated!
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31909f4415bad110)
On 2016/09/29 at 20:57:15, jeffcarp wrote: > On 2016/09/29 at 20:49:43, qyearsley wrote: > > https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... > > File masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py (right): > > > > https://codereview.chromium.org/2382863002/diff/20001/masters/master.chromium... > > masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py:48: B('WebKit Linux Precise', 'f_webkit_linux_rel', scheduler='global_scheduler') > > Looks like these lines are now longer than 80 characters, which is making the presubmit script reject it. > > Updated! Oops, missed a long line, updating.
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2382863002/#ps60001 (title: "Fix missed >80 char line")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL to rename the chromium.webkit master (this one) 2. Land a CL to rename chromium.webkit slaves (https://crrev.com/2382723004) BUG=613305 ========== to ========== Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master Our game plan is to: 1. Land a CL to rename the chromium.webkit master (this one) 2. Land a CL to rename chromium.webkit slaves (https://crrev.com/2382723004) BUG=613305 Committed: https://chromium.googlesource.com/chromium/tools/build/+/801e0732bb06d042e62e... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/801e0732bb06d042e62e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
