Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (https://crrev.com/2382863002)
2. Land a CL to rename chromium.webkit slaves (this one)

BUG=613305
Committed: https://chromium.googlesource.com/chromium/tools/build/+/caf32bee7f928fa4743d71208671779f6d2b570f

[jeffcarp, 2016-09-29 18:26:08]

Description was changed from

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

BUG=613305
==========

to

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (https://crrev.com/2382863002)
2. Land a CL to rename chromium.webkit slaves (this one)

BUG=613305
==========

[jeffcarp, 2016-09-29 18:26:58]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2016-09-29 19:10:38]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-09-29 20:05:12]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:05:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:16:26]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/319062af2b726110)

[Dirk Pranke, 2016-09-29 20:45:11]

lgtm

[qyearsley, 2016-09-29 20:48:27]

On 2016/09/29 at 20:45:11, dpranke wrote:
> lgtm

Looks like you'll need to run scripts/slave/unittests/recipe_simulation_test.py
train (which will write new chromium.expected/*.json files with updated names).

[jeffcarp, 2016-09-29 22:10:44]

On 2016/09/29 at 20:48:27, qyearsley wrote:
> On 2016/09/29 at 20:45:11, dpranke wrote:
> > lgtm
> 
> Looks like you'll need to run
scripts/slave/unittests/recipe_simulation_test.py train (which will write new
chromium.expected/*.json files with updated names).

Ran it and updated CL.

[jeffcarp, 2016-09-29 22:11:00]

The CQ bit was checked by jeffcarp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:11:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:15:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:15:35]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2016-09-30 16:28:05]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2016-09-30 16:28:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2382723004/#ps20001
(title: "Run recipe simulation test")

[commit-bot: I haz the power, 2016-09-30 16:28:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:32:44]

Description was changed from

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (https://crrev.com/2382863002)
2. Land a CL to rename chromium.webkit slaves (this one)

BUG=613305
==========

to

==========
Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (https://crrev.com/2382863002)
2. Land a CL to rename chromium.webkit slaves (this one)

BUG=613305

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/caf32bee7f928fa4743d...
==========

[commit-bot: I haz the power, 2016-09-30 16:32:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/caf32bee7f928fa4743d...

[Michael Achenbach, 2016-10-04 20:23:19]

I suggest renaming bots with 3-way changes.

1. Duplicate bot in recipe with new name
2. Switch name in master + restart
3. Delete old bot in recipe

Otherwise slave-side recipe changes might kick in too early. Is build now pinned
in chromium? If so, the slave-side recipe change takes even longer to roll
through CQ and is very difficult to synchronize with the master changes.