Have handleMaxRecursionDepthExceeded() take an isolate in argument

Have handleMaxRecursionDepthExceeded() take an isolate in argument

Have handleMaxRecursionDepthExceeded() take an isolate in argument to
avoid calling v8::Isolate::GetCurrent().

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157466

[marja, 2013-09-06 11:57:16]

(dcarney, wdyt?)

https://codereview.chromium.org/23470004/diff/1/Source/bindings/v8/V8ScriptRu...
File Source/bindings/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/23470004/diff/1/Source/bindings/v8/V8ScriptRu...
Source/bindings/v8/V8ScriptRunner.cpp:78: v8::Local<v8::Value>
V8ScriptRunner::runCompiledScript(v8::Handle<v8::Script> script,
ScriptExecutionContext* context, v8::Isolate* isolate)
I'm not sure about this... there's also getIsolateFromScriptExecutionContext
which could be used for getting the isolate from the ScriptExecutionContext.
Otoh, that will end up calling v8::Isolate::GetCurrent() (which we want to get
rid of) in some cases.. so should we just plumb the Isolate in in all cases like
this, or what should we do?

[dcarney, 2013-09-06 12:06:19]

On 2013/09/06 11:57:16, marja wrote:
> (dcarney, wdyt?)

I'm okay with either getting it from the ScriptExecutionContext or threading it
everywhere.  If there's no performance implications, I'd say just do the
ScriptExecutionContext lookup.

[haraken, 2013-09-06 16:16:43]

On 2013/09/06 12:06:19, dcarney wrote:
> On 2013/09/06 11:57:16, marja wrote:
> > (dcarney, wdyt?)
> 
> I'm okay with either getting it from the ScriptExecutionContext or threading
it
> everywhere.  If there's no performance implications, I'd say just do the
> ScriptExecutionContext lookup.

I don't have a strong opinion here, but a straightforward rule might be:

- Basically pass an Isolate to all methods (as we've done so far).
- At entry points to Blink, we have a ScriptExecutionContext but don't have an
Isolate. Then, use getIsolateFromScriptExecutionContext() to get an Isolate. And
pass the Isolate around to other methods.

LGTM.

[do-not-use, 2013-09-09 07:01:35]

This still needs approval for Source/web. abarth@ would you mind taking a look
please?

[abarth-chromium, 2013-09-09 17:27:33]

Source/web <--- LGTM

[commit-bot: I haz the power, 2013-09-09 17:27:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23470004/1

[commit-bot: I haz the power, 2013-09-09 18:33:13]

Change committed as 157466