Source/bindings/v8/V8MutationCallback.cpp - Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8MutationCallback.cpp

Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8MutationCallback.cpp

diff --git a/Source/bindings/v8/V8MutationCallback.cpp b/Source/bindings/v8/V8MutationCallback.cpp

index 484666ebca34a4eacab4e8f177e89437dca8a615..07316919492b90df45d62e8d077683c64f19aabd 100644

--- a/Source/bindings/v8/V8MutationCallback.cpp

+++ b/Source/bindings/v8/V8MutationCallback.cpp

@@ -78,7 +78,7 @@ void V8MutationCallback::call(const Vector<RefPtr<MutationRecord> >& mutations,

v8::TryCatch exceptionCatcher;

exceptionCatcher.SetVerbose(true);

- ScriptController::callFunctionWithInstrumentation(scriptExecutionContext(), callback, thisObject, 2, argv);

+ ScriptController::callFunctionWithInstrumentation(scriptExecutionContext(), callback, thisObject, 2, argv, m_isolate);

}

void V8MutationCallback::makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Function>*, V8MutationCallback* callback)