Source/bindings/v8/V8NodeFilterCondition.cpp - Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.cpp

Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NodeFilterCondition.cpp

diff --git a/Source/bindings/v8/V8NodeFilterCondition.cpp b/Source/bindings/v8/V8NodeFilterCondition.cpp

index ec2621e14d6f383917f7e8b06334069139ab67f4..59119531d281d3b701a6c08b2ca00c3d91cc4f4d 100644

--- a/Source/bindings/v8/V8NodeFilterCondition.cpp

+++ b/Source/bindings/v8/V8NodeFilterCondition.cpp

@@ -81,7 +81,7 @@ short V8NodeFilterCondition::acceptNode(ScriptState* state, Node* node) const

args[0] = toV8(node, v8::Handle<v8::Object>(), state->isolate());

v8::Handle<v8::Object> object = v8::Context::GetCurrent()->Global();

- v8::Handle<v8::Value> result = ScriptController::callFunctionWithInstrumentation(0, callback, object, 1, args.get());

+ v8::Handle<v8::Value> result = ScriptController::callFunctionWithInstrumentation(0, callback, object, 1, args.get(), isolate);

if (exceptionCatcher.HasCaught()) {

state->setException(exceptionCatcher.Exception());