Source/bindings/v8/WorkerScriptController.cpp - Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/WorkerScriptController.cpp

Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp

index cbbf758d16dd43363d69cf05307ca3bd3be1de5b..1d500c2ced36ca0e10064294a58d4f6f1898f5e7 100644

--- a/Source/bindings/v8/WorkerScriptController.cpp

+++ b/Source/bindings/v8/WorkerScriptController.cpp

@@ -154,7 +154,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&

v8::Handle<v8::String> scriptString = v8String(script, m_isolate);

v8::Handle<v8::Script> compiledScript = V8ScriptRunner::compileScript(scriptString, fileName, scriptStartPosition, 0, m_isolate);

- v8::Local<v8::Value> result = V8ScriptRunner::runCompiledScript(compiledScript, m_workerGlobalScope);

+ v8::Local<v8::Value> result = V8ScriptRunner::runCompiledScript(compiledScript, m_workerGlobalScope, m_isolate);

if (!block.CanContinue()) {

m_workerGlobalScope->script()->forbidExecution();