Source/bindings/v8/ScriptDebugServer.cpp - Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 23470004: Have handleMaxRecursionDepthExceeded() take an isolate in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp

index 779917eebfb4a09d9dfee4b9d0a52608606c3931..05e65393f7a15c8b868c6a49d1cbb92283945438 100644

--- a/Source/bindings/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/v8/ScriptDebugServer.cpp

@@ -598,7 +598,7 @@ void ScriptDebugServer::runScript(ScriptState* state, const String& scriptId, Sc

return;

v8::Context::Scope contextScope(context);

v8::TryCatch tryCatch;

- v8::Local<v8::Value> value = V8ScriptRunner::runCompiledScript(script, state->scriptExecutionContext());

+ v8::Local<v8::Value> value = V8ScriptRunner::runCompiledScript(script, state->scriptExecutionContext(), m_isolate);

*wasThrown = false;

if (tryCatch.HasCaught()) {

*wasThrown = true;