Update libsrtp to version 2.0

Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376
Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/7baef709753e8920ecf881558ade2095cd6387f9

[mattdr-at-chromium, 2016-10-04 23:32:48]

Description was changed from

==========
Update libsrtp to version 2.0

BUG=
==========

to

==========
Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376
==========

[mattdr-at-chromium, 2016-10-04 23:32:49]

mattdr@chromium.org changed reviewers:
+ kjellander@chromium.org, phoglund@chromium.org

[kjellander_chromium, 2016-10-05 07:14:13]

Nice work! I just have a few minor comments on BUILD.gn but I won't block you on
them. LGTM.
I assume you also ran the tests and they passed?

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode1
BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights reserved.
nit: according to the style guide, year shouldn't be updated (only when new
files are added).

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode47
BUILD.gn:47: ".",
I don't believe you need "." in the GN world. It's supposed to always be
included (but please verify if you remove it).

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode117
BUILD.gn:117: test("srtp_test_${target_name}") {
add testonly = true to the template.

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode167
BUILD.gn:167: executable("rtpw") {
It looks like this can also use the srtp_test template, no?

[kjellander_chromium, 2016-10-05 07:15:20]

On 2016/10/05 07:14:13, kjellander_chromium wrote:
> Nice work! I just have a few minor comments on BUILD.gn but I won't block you
on
> them. LGTM.
> I assume you also ran the tests and they passed?
> 
> https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode1
> BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights reserved.
> nit: according to the style guide, year shouldn't be updated (only when new
> files are added).
> 
> https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode47
> BUILD.gn:47: ".",
> I don't believe you need "." in the GN world. It's supposed to always be
> included (but please verify if you remove it).
> 
> https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode117
> BUILD.gn:117: test("srtp_test_${target_name}") {
> add testonly = true to the template.
> 
> https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode167
> BUILD.gn:167: executable("rtpw") {
> It looks like this can also use the srtp_test template, no?

Another thing, when creating the roll-CL for Chromium's DEPS, can you add
webrtc-perf-sheriffs@google.com as CC? 
Then it'll be easier for the perf sheriff to know about this change, since I
imagine it might trigger perf alerts (hopefully only improvements).

[phoglund_chromium, 2016-10-05 07:31:59]

Not sure if I can contribute much here, but as far I can tell this looks great!
lgtm

[mattdr-at-chromium, 2016-10-05 08:46:41]

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode1
BUILD.gn:1: # Copyright 2016 The Chromium Authors. All rights reserved.
On 2016/10/05 07:14:13, kjellander_chromium wrote:
> nit: according to the style guide, year shouldn't be updated (only when new
> files are added).

Reverted

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode47
BUILD.gn:47: ".",
On 2016/10/05 07:14:12, kjellander_chromium wrote:
> I don't believe you need "." in the GN world. It's supposed to always be
> included (but please verify if you remove it).

Confirmed. Removed.

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode117
BUILD.gn:117: test("srtp_test_${target_name}") {
On 2016/10/05 07:14:12, kjellander_chromium wrote:
> add testonly = true to the template.

Done.

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode167
BUILD.gn:167: executable("rtpw") {
On 2016/10/05 07:14:13, kjellander_chromium wrote:
> It looks like this can also use the srtp_test template, no?

The two differ slightly in sources and defines, so I split out rtpw.

[mattdr-at-chromium, 2016-10-05 09:02:21]

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode47
BUILD.gn:47: ".",
On 2016/10/05 08:46:41, mattdr-at-chromium wrote:
> On 2016/10/05 07:14:12, kjellander_chromium wrote:
> > I don't believe you need "." in the GN world. It's supposed to always be
> > included (but please verify if you remove it).
> 
> Confirmed. Removed.

I spoke too soon. Without this, srtpfilter_unittest fails to compile because of
this line:
#include "crypto/include/err.h"

[mattdr-at-chromium, 2016-10-05 09:10:23]

Henrik, if this seems okay to you can I impose on you for your commit powers?

[kjellander_chromium, 2016-10-05 09:17:12]

lgtm

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode47
BUILD.gn:47: ".",
On 2016/10/05 09:02:21, mattdr-at-chromium wrote:
> On 2016/10/05 08:46:41, mattdr-at-chromium wrote:
> > On 2016/10/05 07:14:12, kjellander_chromium wrote:
> > > I don't believe you need "." in the GN world. It's supposed to always be
> > > included (but please verify if you remove it).
> > 
> > Confirmed. Removed.
> 
> I spoke too soon. Without this, srtpfilter_unittest fails to compile because
of
> this line:
> #include "crypto/include/err.h"

That's weird. Well, if it fails it fails :)

https://codereview.chromium.org/2344973002/diff/40001/BUILD.gn#newcode167
BUILD.gn:167: executable("rtpw") {
On 2016/10/05 08:46:41, mattdr-at-chromium wrote:
> On 2016/10/05 07:14:13, kjellander_chromium wrote:
> > It looks like this can also use the srtp_test template, no?
> 
> The two differ slightly in sources and defines, so I split out rtpw.

OK, I mostly wanted to check, since the other tests also don't have all the
stuff of the srtp_test template in their previous versions, so I thought the
template might be usable here to. I'll leave it to you to decide.

[kjellander_chromium, 2016-10-05 11:45:08]

On 2016/10/05 09:10:23, mattdr-at-chromium wrote:
> Henrik, if this seems okay to you can I impose on you for your commit powers?

Sure, but I'm unable to patch this locally since the CL is "too large".
Can you mail me a zipped git patch created using 'git format-patch' ? Then I can
submit that.

[kjellander_chromium, 2016-10-06 08:59:02]

Description was changed from

==========
Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376
==========

to

==========
Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376
R=kjellander@chromium.org, phoglund@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/libsrtp/+/7baef709753e8920ecf...
==========

[kjellander_chromium, 2016-10-06 08:59:03]

On 2016/10/05 11:45:08, kjellander_chromium wrote:
> On 2016/10/05 09:10:23, mattdr-at-chromium wrote:
> > Henrik, if this seems okay to you can I impose on you for your commit
powers?
> 
> Sure, but I'm unable to patch this locally since the CL is "too large".
> Can you mail me a zipped git patch created using 'git format-patch' ? Then I
can
> submit that.

[kjellander_chromium, 2016-10-06 08:59:05]

Committed patchset #7 (id:60001) manually as
7baef709753e8920ecf881558ade2095cd6387f9 (presubmit successful).

[kjellander_chromium, 2016-10-06 09:00:13]

Description was changed from

==========
Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376
==========

to

==========
Update libsrtp to version 2.0

Delete libsrtp.gyp.

BUG=webrtc:6376

Committed:
https://chromium.googlesource.com/chromium/deps/libsrtp/+/7baef709753e8920ecf...
==========

[kjellander_chromium, 2016-10-06 09:01:24]

On 2016/10/06 08:59:05, kjellander_chromium wrote:
> Committed patchset #7 (id:60001) manually as
> 7baef709753e8920ecf881558ade2095cd6387f9 (presubmit successful).

Committed now with 'git cl land'. I guess I couldn't close the CL from command
line since I didn't own it or something, so I did that manually via the Web UI
now.
I verified the number of added/removed lines were identical to your CL, so the
commit should be identical.
See
https://chromium.googlesource.com/chromium/deps/libsrtp/+/7baef709753e8920ecf...
for details.