Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. Committed: https://crrev.com/b64565e5d6bed90401e6f2f4a9dad3bace701b25 Cr-Commit-Position: refs/heads/master@{#39445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -190 lines) Patch
M src/builtins/builtins-handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-15 09:18:52 UTC) #5
mvstanton
lgtm
4 years, 3 months ago (2016-09-15 11:06:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2343813002/20001
4 years, 3 months ago (2016-09-15 11:07:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-15 11:10:34 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 11:10:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b64565e5d6bed90401e6f2f4a9dad3bace701b25
Cr-Commit-Position: refs/heads/master@{#39445}

Powered by Google App Engine
This is Rietveld 408576698