Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Side by Side Diff: src/ic/ia32/ic-ia32.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 752 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 763
764 764
765 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 765 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
766 // Return address is on the stack. 766 // Return address is on the stack.
767 StoreIC_PushArgs(masm); 767 StoreIC_PushArgs(masm);
768 768
769 // Do tail-call to runtime routine. 769 // Do tail-call to runtime routine.
770 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 770 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
771 } 771 }
772 772
773 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
774 // Return address is on the stack.
775 StoreIC_PushArgs(masm);
776
777 // Do tail-call to runtime routine.
778 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
779 }
773 780
774 #undef __ 781 #undef __
775 782
776 783
777 Condition CompareIC::ComputeCondition(Token::Value op) { 784 Condition CompareIC::ComputeCondition(Token::Value op) {
778 switch (op) { 785 switch (op) {
779 case Token::EQ_STRICT: 786 case Token::EQ_STRICT:
780 case Token::EQ: 787 case Token::EQ:
781 return equal; 788 return equal;
782 case Token::LT: 789 case Token::LT:
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 Condition cc = 847 Condition cc =
841 (check == ENABLE_INLINED_SMI_CHECK) 848 (check == ENABLE_INLINED_SMI_CHECK)
842 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 849 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
843 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 850 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
844 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 851 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
845 } 852 }
846 } // namespace internal 853 } // namespace internal
847 } // namespace v8 854 } // namespace v8
848 855
849 #endif // V8_TARGET_ARCH_IA32 856 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips/handler-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698