Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: src/ic/s390/ic-s390.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/ic.h" 7 #include "src/ic/ic.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 StoreWithVectorDescriptor::SlotRegister(), 442 StoreWithVectorDescriptor::SlotRegister(),
443 StoreWithVectorDescriptor::VectorRegister()); 443 StoreWithVectorDescriptor::VectorRegister());
444 } 444 }
445 445
446 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 446 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
447 StoreIC_PushArgs(masm); 447 StoreIC_PushArgs(masm);
448 448
449 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 449 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
450 } 450 }
451 451
452 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
453 StoreIC_PushArgs(masm);
454
455 // The slow case calls into the runtime to complete the store without causing
456 // an IC miss that would otherwise cause a transition to the generic stub.
457 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
458 }
459
452 static void KeyedStoreGenerateMegamorphicHelper( 460 static void KeyedStoreGenerateMegamorphicHelper(
453 MacroAssembler* masm, Label* fast_object, Label* fast_double, Label* slow, 461 MacroAssembler* masm, Label* fast_object, Label* fast_double, Label* slow,
454 KeyedStoreCheckMap check_map, KeyedStoreIncrementLength increment_length, 462 KeyedStoreCheckMap check_map, KeyedStoreIncrementLength increment_length,
455 Register value, Register key, Register receiver, Register receiver_map, 463 Register value, Register key, Register receiver, Register receiver_map,
456 Register elements_map, Register elements) { 464 Register elements_map, Register elements) {
457 Label transition_smi_elements; 465 Label transition_smi_elements;
458 Label finish_object_store, non_double_value, transition_double_elements; 466 Label finish_object_store, non_double_value, transition_double_elements;
459 Label fast_double_without_map_check; 467 Label fast_double_without_map_check;
460 468
461 // Fast case: Do the store, could be either Object or double. 469 // Fast case: Do the store, could be either Object or double.
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 patcher.masm()->brcl(cc, Operand((branch_instr & 0xffffffff) << 1)); 874 patcher.masm()->brcl(cc, Operand((branch_instr & 0xffffffff) << 1));
867 } else { 875 } else {
868 DCHECK(false); 876 DCHECK(false);
869 } 877 }
870 } 878 }
871 879
872 } // namespace internal 880 } // namespace internal
873 } // namespace v8 881 } // namespace v8
874 882
875 #endif // V8_TARGET_ARCH_S390 883 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698