Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/x64/ic-x64.cc

Issue 2343813002: [ic] Move KeyedStoreIC::GenerateSlow() to ic-XXX.cc to avoid code duplication. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 757
758 758
759 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 759 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
760 // Return address is on the stack. 760 // Return address is on the stack.
761 StoreIC_PushArgs(masm); 761 StoreIC_PushArgs(masm);
762 762
763 // Do tail-call to runtime routine. 763 // Do tail-call to runtime routine.
764 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss); 764 __ TailCallRuntime(Runtime::kKeyedStoreIC_Miss);
765 } 765 }
766 766
767 void KeyedStoreIC::GenerateSlow(MacroAssembler* masm) {
768 // Return address is on the stack.
769 StoreIC_PushArgs(masm);
770
771 // Do tail-call to runtime routine.
772 __ TailCallRuntime(Runtime::kKeyedStoreIC_Slow);
773 }
767 774
768 #undef __ 775 #undef __
769 776
770 777
771 Condition CompareIC::ComputeCondition(Token::Value op) { 778 Condition CompareIC::ComputeCondition(Token::Value op) {
772 switch (op) { 779 switch (op) {
773 case Token::EQ_STRICT: 780 case Token::EQ_STRICT:
774 case Token::EQ: 781 case Token::EQ:
775 return equal; 782 return equal;
776 case Token::LT: 783 case Token::LT:
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 Condition cc = 841 Condition cc =
835 (check == ENABLE_INLINED_SMI_CHECK) 842 (check == ENABLE_INLINED_SMI_CHECK)
836 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 843 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
837 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 844 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
838 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 845 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
839 } 846 }
840 } // namespace internal 847 } // namespace internal
841 } // namespace v8 848 } // namespace v8
842 849
843 #endif // V8_TARGET_ARCH_X64 850 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698